Skip to content

Rollup of 5 pull requests - #116175

Merged
bors merged 10 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-cwteiwy
Sep 26, 2023
Merged

Rollup of 5 pull requests#116175
bors merged 10 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-cwteiwy

Conversation

@matthiaskrgr

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

eduardosmand others added 10 commits September 23, 2023 13:21
Rename `cold_path` to `outline`
I find this name to be a bit more descriptive.
r? ``@oli-obk``
…=fmease
Fix typo in rustdoc unstable features doc
Update books
## rust-embedded/book
1 commits in 99ad2847b865e96d8ae7b333d3ee96963557e621..eac173690b8cc99094e1d88bd49dd61127fbd285
2023-09-12 07:34:44 UTC to 2023-09-12 07:34:44 UTC
- USB connector-type correction (rust-embedded/book#360)
## rust-lang/nomicon
1 commits in e3f3af69dce71cd37a785bccb7e58449197d940c..ddfa4214487686e91b21aa29afb972c08a8f0d5b
2023-09-22 17:04:10 UTC to 2023-09-22 17:04:10 UTC
- Fill "Beneath `std`" (rust-lang/nomicon#413)
## rust-lang/reference
1 commits in ee7c676fd6e287459cb407337652412c990686c0..5262e1c3b43a2c489df8f6717683a44c7a2260fd
2023-09-18 18:28:31 UTC to 2023-09-18 18:28:31 UTC
- we reserve the right to reduce our amount of UB (rust-lang/reference#1397)
## rust-lang/rustc-dev-guide
8 commits in 08bb147..a13b7c2
2023-09-25 05:14:41 UTC to 2023-09-11 21:29:18 UTC
- Clarify all the `{AP,RP}IT{,IT}` impl trait types (rust-lang/rustc-dev-guide#1798)
- Modify build instructions for optimized build (rust-lang/rustc-dev-guide#1795)
- Remove outdated references to coverage debug code (rust-lang/rustc-dev-guide#1797)
- Add deep dive document about early/late bound parameters interacting with turbofish (rust-lang/rustc-dev-guide#1794)
- explain the MIR const vs TY const situation (rust-lang/rustc-dev-guide#1793)
- fix type name (rust-lang/rustc-dev-guide#1792)
- Clarify that `run-coverage` only runs in some of the CI jobs (rust-lang/rustc-dev-guide#1791)
- Document the `coverage-map` and `run-coverage` test suites (rust-lang/rustc-dev-guide#1790)
…intrinsic, r=Nilstrieb
Gate and validate `#[rustc_safe_intrinsic]`
Copied over from rust-lang#116159:
> This was added as ungated in https://github.com/rust-lang/rust/pull/100719/files#diff-09c366d3ad3ec9a42125253b610ca83cad6b156aa2a723f6c7e83eddef7b1e8fR502, probably because the author looked at the surrounding attributes, which are ungated because they are gated specially behind the staged_api feature.
>
> I don't think we need to crater this, the attribute is entirely useless without the intrinsics feature, which is already unstable..
r? ``@Nilstrieb``
@rustbotrustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 26, 2023
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Sep 26, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 6f4a0a1 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2023
@bors

bors commented Sep 26, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 6f4a0a1 with merge 21627d6...

@bors

bors commented Sep 26, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 21627d6 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 26, 2023
@bors
bors merged commit 21627d6 into rust-lang:masterSep 26, 2023
@rustbotrustbot added this to the 1.74.0 milestone Sep 26, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#116099Add regression test for issue #79865aec2946a3d0414860a6a860a65bc9c50bf8ecddd (link)
#116131Rename cold_path to outline85bf748f7a3b9a738a8f7b830e047b4a14361f18 (link)
#116151Fix typo in rustdoc unstable features doc722694dd3e8cef1ab52faa30502b461427dbb1f1 (link)
#116153Update booksdbc7924f435b7c461e4eae5a96ed8107f856e316 (link)
#116162Gate and validate #[rustc_safe_intrinsic]95f4975bb9c1ffc267a57509d685dd3592bcef5f (link)

previous master: 1f2bacf677

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (21627d6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
0.7%[0.7%, 0.7%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.9%[-0.9%, -0.9%]1
Improvements ✅
(secondary)
-0.5%[-0.5%, -0.5%]1
All ❌✅ (primary)-0.1%[-0.9%, 0.7%]2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.892s -> 631.291s (0.06%)
Artifact size: 317.28 MiB -> 317.28 MiB (0.00%)

@matthiaskrgr
matthiaskrgr deleted the rollup-cwteiwy branch March 16, 2024 18:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@matthiaskrgr@bors@rust-timer@rustbot@eduardosm@DaniPopes@fmease@Zoxc