Skip to content

Update LLVM submodule - #116227

Merged
bors merged 1 commit into
rust-lang:masterfrom
nikic:update-llvm-14
Sep 28, 2023
Merged

Update LLVM submodule#116227
bors merged 1 commit into
rust-lang:masterfrom
nikic:update-llvm-14

Conversation

@nikic

@nikicnikic commented Sep 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Update LLVM submodule to pull in additional 17.x backports.

Fixes#115970.
Fixes miscompile from #115554.
Fixes miscompile from #102099.
Fixes inlining regressions mentioned at rust-lang/llvm-project#153.

@rustbot

rustbot commented Sep 28, 2023

Copy link
Copy Markdown
Collaborator

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot

rustbot commented Sep 28, 2023

Copy link
Copy Markdown
Collaborator

⚠️Warning⚠️

  • These commits modify submodules.

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2023
@nikicnikic added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 28, 2023
@wesleywiser

wesleywiser commented Sep 28, 2023

Copy link
Copy Markdown
Member

@bors p=5

Fixes P-high beta issues

@apiraino

apiraino commented Sep 28, 2023

Copy link
Copy Markdown
Contributor

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 28, 2023
@cuviper

cuviper commented Sep 28, 2023

Copy link
Copy Markdown
Member

@bors r+ rollup=never

@bors

bors commented Sep 28, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit b325e9c has been approved by cuviper

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2023
@bors

bors commented Sep 28, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b325e9c with merge 42faef5...

@bors

bors commented Sep 28, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 42faef5 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2023
@bors
bors merged commit 42faef5 into rust-lang:masterSep 28, 2023
@rustbotrustbot added this to the 1.74.0 milestone Sep 28, 2023
@rust-timer

rust-timer commented Sep 28, 2023

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (42faef5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-2.0%[-2.0%, -2.0%]1
All ❌✅ (primary)--0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		0.2%[0.2%, 0.2%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)--0

Bootstrap: 630.455s -> 631.024s (0.09%)
Artifact size: 317.31 MiB -> 317.33 MiB (0.01%)

@cuvipercuviper mentioned this pull request Sep 29, 2023
Merged
@cuvipercuviper modified the milestones: 1.74.0, 1.73.0Sep 29, 2023
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 29, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 29, 2023
@bors
Auto merge ofrust-lang#116279- cuviper:beta-next, r=cuviper
2ce543c
[beta] backports
- Only prevent field projections into opaque types, not types containing opaque types rust-lang#116156
- Update LLVM submodule rust-lang#116227
r? cuviper
@cuvipercuviper mentioned this pull request Oct 2, 2023
Closed
@workingjubileeworkingjubilee added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuvipercuviper

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.73.0

Development

Successfully merging this pull request may close these issues.

Infinite loop in LLVM 17 (DominatorTreeBase)

8 participants

@nikic@rustbot@wesleywiser@apiraino@cuviper@bors@rust-timer@workingjubilee