Uh oh!
There was an error while loading. Please reload this page.
Update windows-bindgen and define INVALID_HANDLE_VALUE ourselves - #117656
Merged
Conversation
rustbot
commented
Nov 7, 2023
Collaborator
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
rustbot
commented
Nov 17, 2023
Collaborator
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
INVALID_HANDLE_VALUE ourselvesINVALID_HANDLE_VALUE ourselvesthomcc
commented
Nov 24, 2023
Member
@bors r+ |
bors
commented
Nov 24, 2023
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#116807 (Improve rewind documentation) - rust-lang#117656 (Update windows-bindgen and define `INVALID_HANDLE_VALUE` ourselves) - rust-lang#117940 (chore: remove unnecessary drop) - rust-lang#118028 (Document behavior of `<dyn Any as Any>::type_id()`) - rust-lang#118060 (Use an absolute path to the NUL device) - rust-lang#118224 (Sort unstable items last in rustdoc, instead of first) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2023
Rollup merge of rust-lang#117656 - ChrisDenton:invalid, r=thomcc Update windows-bindgen and define `INVALID_HANDLE_VALUE` ourselves We generate bindings to the Windows API via the `windows-bindgen` crate, which is ultimately what's also used to generate the `windows-sys` and `windows` crates. However, there currently is some custom sauce just for std which makes it a bit different from the vanilla bindings. I would love for us to reduce and eventually remove the differences entirely so that std is using the exact same bindings as everyone else. Maybe in the future we can even just have a normal dependency on `windows-sys`. This PR removes one of those special things. Our definition of `INVALID_HANDLE_VALUE` relies on an experimental nightly feature for strict provenance, so lets bring that back in house. It also excludes it from the codegen step though that isn't strictly necessary as we override it in any case. This PR also updates windows-bingen to 0.52.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We generate bindings to the Windows API via the
windows-bindgencrate, which is ultimately what's also used to generate thewindows-sysandwindowscrates. However, there currently is some custom sauce just for std which makes it a bit different from the vanilla bindings. I would love for us to reduce and eventually remove the differences entirely so that std is using the exact same bindings as everyone else. Maybe in the future we can even just have a normal dependency onwindows-sys.This PR removes one of those special things. Our definition of
INVALID_HANDLE_VALUErelies on an experimental nightly feature for strict provenance, so lets bring that back in house. It also excludes it from the codegen step though that isn't strictly necessary as we override it in any case.This PR also updates windows-bingen to 0.52.0.