Skip to content

Request that rust-analyzer changes are sent upstream first if possible - #118255

Merged
bors merged 1 commit into
rust-lang:masterfrom
dtolnay:mentionsrustanalyzer
Nov 25, 2023
Merged

Request that rust-analyzer changes are sent upstream first if possible#118255
bors merged 1 commit into
rust-lang:masterfrom
dtolnay:mentionsrustanalyzer

Conversation

@dtolnay

Copy link
Copy Markdown
Member

This automates @lnicola's comment #118253 (comment).

Rustbot will write a comment similar to #116743 (comment).

@rustbot

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2023
@dtolnay
dtolnayforce-pushed the mentionsrustanalyzer branch from c52cec5 to 7a6dce3CompareNovember 24, 2023 17:17
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Nov 24, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 7a6dce3 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2023
@fmeasefmease mentioned this pull request Nov 25, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2023
Rollup of 9 pull requests
Successful merges:
- rust-lang#118220 (general improvements/fixes on bootstrap)
- rust-lang#118251 (rustdoc-search: avoid infinite where clause unbox)
- rust-lang#118253 (Replace `option.map(cond) == Some(true)` with `option.is_some_and(cond)`)
- rust-lang#118255 (Request that rust-analyzer changes are sent upstream first if possible)
- rust-lang#118259 (Move EagerResolution to rustc_infer::infer::resolve)
- rust-lang#118262 (Relate Inherent Associated Types using eq)
- rust-lang#118266 (Move stuff around on `stable_mir` and `rustc_smir` crate)
- rust-lang#118271 (Separate `NaN`/`Inf` floats with `_`)
- rust-lang#118274 (Fix smir's `Ty::Ref` pretty printing)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 969a773 into rust-lang:masterNov 25, 2023
@rustbotrustbot added this to the 1.76.0 milestone Nov 25, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2023
Rollup merge of rust-lang#118255 - dtolnay:mentionsrustanalyzer, r=Mark-Simulacrum
Request that rust-analyzer changes are sent upstream first if possible
This automates `@lnicola's` comment rust-lang#118253 (comment).
Rustbot will write a comment similar to rust-lang#116743 (comment).
@dtolnay
dtolnay deleted the mentionsrustanalyzer branch November 25, 2023 15:23
@dtolnaydtolnay removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@dtolnay@rustbot@Mark-Simulacrum@bors@lnicola