Uh oh!
There was an error while loading. Please reload this page.
Use is_{some,ok}_and more in the compiler - #118288
Merged
Merged
Conversation
rustbot
commented
Nov 25, 2023
Collaborator
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
rustbot
commented
Nov 25, 2023
Collaborator
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino, @ouz-a |
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
compiler-errorsforce-pushed
the
is_some_and
branch
from
November 25, 2023 17:40
5df4fb6 to
7f47f22Comparelqd
approved these changes
Nov 25, 2023
compiler-errors
commented
Nov 25, 2023
ContributorAuthor
@bors r=lqd |
bors
commented
Nov 25, 2023
Collaborator
dtolnay
requested changes
Nov 25, 2023
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 25, 2023
Use `is_{some,ok}_and` more in the compiler
slightly more fluent-reading codecompiler-errorsforce-pushed
the
is_some_and
branch
from
November 25, 2023 18:47
7f47f22 to
079a2e8Comparedtolnay
approved these changes
Nov 25, 2023
dtolnay
commented
Nov 25, 2023
Member
@bors r=lqd,dtolnay |
bors
commented
Nov 25, 2023
Collaborator
compiler-errors
commented
Nov 25, 2023
ContributorAuthor
@bors rollup |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2023
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#117651 (coverage: Simplify building coverage expressions based on sums) - rust-lang#117968 (Stabilize `ptr::addr_eq`) - rust-lang#118158 (Reduce fluent boilerplate) - rust-lang#118201 (Miscellaneous `ObligationCauseCode` cleanups) - rust-lang#118288 (Use `is_{some,ok}_and` more in the compiler) - rust-lang#118289 (`is_{some,ok}_and` for rustdoc) - rust-lang#118290 (Don't ICE when encountering placeholders in implied bounds computation) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 26, 2023
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#117651 (coverage: Simplify building coverage expressions based on sums) - rust-lang#117968 (Stabilize `ptr::addr_eq`) - rust-lang#118158 (Reduce fluent boilerplate) - rust-lang#118201 (Miscellaneous `ObligationCauseCode` cleanups) - rust-lang#118288 (Use `is_{some,ok}_and` more in the compiler) - rust-lang#118289 (`is_{some,ok}_and` for rustdoc) - rust-lang#118290 (Don't ICE when encountering placeholders in implied bounds computation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 26, 2023
Rollup merge of rust-lang#118288 - compiler-errors:is_some_and, r=lqd,dtolnay Use `is_{some,ok}_and` more in the compiler slightly more fluent-reading code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slightly more fluent-reading code