Uh oh!
There was an error while loading. Please reload this page.
rustc_session: Address all rustc::potential_query_instability lints - #118574
Merged
Conversation
Instead of allowing `rustc::potential_query_instability` on the whole crate we go over each lint and allow it individually if it is safe to do. Turns out all instances were safe to allow in this crate.
rustbot
commented
Dec 3, 2023
Collaborator
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
cjgillot
commented
Dec 3, 2023
Contributor
@bors r+ rollup |
bors
commented
Dec 3, 2023
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 3, 2023
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#117869 ([rustdoc] Add highlighting for comments in items declaration) - rust-lang#118525 (coverage: Skip spans that can't be un-expanded back to the function body) - rust-lang#118574 (rustc_session: Address all `rustc::potential_query_instability` lints) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 3, 2023
Rollup merge of rust-lang#118574 - Enselic:query-instability, r=cjgillot rustc_session: Address all `rustc::potential_query_instability` lints Instead of allowing `rustc::potential_query_instability` on the whole crate we go over each lint and allow it individually if it is safe to do. Turns out all instances were safe to allow in this crate. Part of rust-lang#84447 which is **E-help-wanted**.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of allowing
rustc::potential_query_instabilityon the whole crate we go over each lint and allow it individually if it is safe to do. Turns out all instances were safe to allow in this crate.Part of #84447 which is E-help-wanted.