Uh oh!
There was an error while loading. Please reload this page.
Encode CoroutineKind directly - #119173
Conversation
compiler-errors
commented
Dec 21, 2023
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
bors
commented
Dec 21, 2023
…<try> Encode `CoroutineKind` directly Probably a quick optimization? r? `@ghost`
bors
commented
Dec 21, 2023
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Dec 21, 2023
Finished benchmarking commit (c07fac8): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 672.809s -> 671.894s (-0.14%) |
compiler-errors
commented
Dec 21, 2023
eh, this should slightly decrease metadata size for async heavy crates i think r? compiler |
TaKO8Ki
commented
Dec 21, 2023
@bors r+ |
bors
commented
Dec 21, 2023
bors
commented
Dec 21, 2023
…TaKO8Ki Encode `CoroutineKind` directly Probably a quick optimization? r? `@ghost`
bors
commented
Dec 21, 2023
💔 Test failed - checks-actions |
emilyalbini
commented
Dec 21, 2023
This was stuck uploading artifacts to S3, killed the job. @bors retry |
rust-log-analyzer
commented
Dec 21, 2023
bors
commented
Dec 22, 2023
bors
commented
Dec 22, 2023
☀️ Test successful - checks-actions |
rust-timer
commented
Dec 22, 2023
Finished benchmarking commit (ef1b78e): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 673.306s -> 673.496s (0.03%) |
Probably a quick optimization?
r? @ghost