Skip to content

Make broken MIR a proper lint. - #119260

Draft
cjgillot wants to merge 1 commit into
rust-lang:mainfrom
cjgillot:mir-lint
Draft

Make broken MIR a proper lint.#119260
cjgillot wants to merge 1 commit into
rust-lang:mainfrom
cjgillot:mir-lint

Conversation

@cjgillot

@cjgillotcjgillot commented Dec 23, 2023

Copy link
Copy Markdown
Contributor

This allows to use expect(rustc::broken_mir) when we actually expect it to fire.

cc @tmiasko

@matthiaskrgr this should address #119077 (comment)

@rustbot

rustbot commented Dec 23, 2023

Copy link
Copy Markdown
Collaborator

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 23, 2023
@rustbot

rustbot commented Dec 23, 2023

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
compiler-errors
compiler-errors reviewed Dec 26, 2023
View reviewed changes
Comment threadcompiler/rustc_lint_defs/src/builtin.rs
/// The `broken_mir` statically detects undefined behaviour in the MIR optimization pipeline.
/// This is an internal lint, and not intended to be used directly.
pub rustc::BROKEN_MIR,
Deny,

@compiler-errorscompiler-errorsDec 26, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forbid maybe?

@cjgillotcjgillotAug 3, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One use case is to use expect. And you cannot expect a forbidden lint.

tmiasko
tmiasko reviewed Dec 27, 2023
View reviewed changes
Comment threadcompiler/rustc_lint_defs/src/builtin.rs
Comment on lines +3959 to +3966
crate::declare_tool_lint! {
/// The `broken_mir` statically detects undefined behaviour in the MIR optimization pipeline.
/// This is an internal lint, and not intended to be used directly.
pub rustc::BROKEN_MIR,
Deny,
"broken MIR",
report_in_external_macro: true
}

@tmiaskotmiaskoDec 27, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bike-shedding: The term broken MIR is already used when validation fails. It also overstates the severity of what is being reported. Maybe unusual MIR?

@compiler-errorscompiler-errorsDec 30, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do believe broken is the right term here

@tmiaskotmiaskoAug 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what sense is this MIR broken?

The motivation behind moving those checks out of validator was the fact that there is nothing inherently wrong about violating them. Those reports should NOT be treated as bugs. It doesn't even mean that the user provided program has an undefined behaviour, since we don't know whether those instructions are ever executed.

@bors

bors commented Dec 30, 2023

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #119377) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot
cjgillotforce-pushed the mir-lint branch 2 times, most recently from 1176c87 to 0cbefd5CompareJanuary 1, 2024 02:43
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Jan 5, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #119621) made this pull request unmergeable. Please resolve the merge conflicts.

@compiler-errors

compiler-errors commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

@rustbot author

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2024
@Dylan-DPC

Dylan-DPC commented Aug 2, 2024

Copy link
Copy Markdown
Member

@cjgillot any updates on this? thanks

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Aug 19, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #129261) made this pull request unmergeable. Please resolve the merge conflicts.

@alex-semenyukalex-semenyuk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 23, 2024
@JohnCSimon

JohnCSimon commented Feb 5, 2025•
edited
Loading

Copy link
Copy Markdown

@cjgillot

ping from triage - can you post your status on this PR? There hasn't been an update in a few months, and there are build and merge conflicts. Thanks!

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cjgillot
cjgillot marked this pull request as draft July 14, 2025 05:53
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

rust-log-analyzer commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors

bors commented Dec 19, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #150110) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmiaskotmiaskotmiasko left review comments
+1 more reviewer
@compiler-errorscompiler-errorscompiler-errors left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@TaKO8KiTaKO8Ki

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@cjgillot@rustbot@rust-log-analyzer@bors@compiler-errors@Dylan-DPC@JohnCSimon@tmiasko@alex-semenyuk@TaKO8Ki