Uh oh!
There was an error while loading. Please reload this page.
Update to bitflags 2 in the compiler - #119446
Merged
Merged
Conversation
Noratrieb
marked this pull request as ready for review
December 30, 2023 16:10
rustbot
commented
Dec 30, 2023
Collaborator
These commits modify compiler targets. |
Noratrieb
commented
Dec 30, 2023
MemberAuthor
I meant to r? compiler-errors |
This comment has been minimized.
This comment has been minimized.
Noratriebforce-pushed
the
bitflags2.0-hell
branch
from
December 30, 2023 16:15
2cb6969 to
8047b6cComparerustbot
commented
Dec 30, 2023
Collaborator
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
compiler-errors
approved these changes
Dec 30, 2023
| @@ -150,3 +150,14 @@ pub fn make_display(f: impl Fn(&mut fmt::Formatter<'_>) -> fmt::Result) -> impl | |||
| // See comments in src/librustc_middle/lib.rs | |||
| #[doc(hidden)] | |||
| pub fn __noop_fix_for_27438() {} | |||
Contributor
There was a problem hiding this comment.
__noop_fix_for_27438
what the heck is this
MemberAuthor
There was a problem hiding this comment.
good solutions for good problems (some windows shared library shenanigans apparently?)
This comment has been minimized.
This comment has been minimized.
3 tasks
Noratriebforce-pushed
the
bitflags2.0-hell
branch
from
December 30, 2023 16:45
8047b6c to
8743bcaCompare
This comment has been minimized.
This comment has been minimized.
This involves lots of breaking changes. There are two big changes that force changes. The first is that the bitflag types now don't automatically implement normal derive traits, so we need to derive them manually. Additionally, bitflags now have a hidden inner type by default, which breaks our custom derives. The bitflags docs recommend using the impl form in these cases, which I did.
Noratriebforce-pushed
the
bitflags2.0-hell
branch
from
December 30, 2023 17:17
8743bca to
ffafcd8Comparecompiler-errors
commented
Dec 30, 2023
Contributor
r=me |
Noratrieb
commented
Dec 30, 2023
MemberAuthor
@bors r=compiler-errors |
bors
commented
Dec 30, 2023
Collaborator
bors
commented
Dec 30, 2023
Collaborator
bors
commented
Dec 30, 2023
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Dec 30, 2023
Collaborator
Finished benchmarking commit (5a345b3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 668.901s -> 669.431s (0.08%) |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 16, 2024
Fix `rustc_abi` build on stable rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
compiler-errors added a commit
to compiler-errors/rust
that referenced
this pull request
Jan 17, 2024
Fix `rustc_abi` build on stable rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 17, 2024
Fix `rustc_abi` build on stable rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
compiler-errors added a commit
to compiler-errors/rust
that referenced
this pull request
Jan 17, 2024
Fix `rustc_abi` build on stable rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 17, 2024
Fix `rustc_abi` build on stable rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2024
Rollup merge of rust-lang#120032 - Nadrieril:fix-rustc_abi, r=Nilstrieb Fix `rustc_abi` build on stable rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This involves lots of breaking changes. There are two big changes that force changes. The first is that the bitflag types now don't automatically implement normal derive traits, so we need to derive them manually.
Additionally, bitflags now have a hidden inner type by default, which breaks our custom derives. The bitflags docs recommend using the impl form in these cases, which I did.
r? compiler