Skip to content

Temporarily disable M1 runners on GitHub Actions - #119546

Merged
bors merged 1 commit into
rust-lang:masterfrom
jdno:temporarily-disable-m1-runners
Jan 3, 2024
Merged

Temporarily disable M1 runners on GitHub Actions#119546
bors merged 1 commit into
rust-lang:masterfrom
jdno:temporarily-disable-m1-runners

Conversation

@jdno

@jdnojdno commented Jan 3, 2024

Copy link
Copy Markdown
Member

This commit temporarily reverts the addition of M1 runners on GitHub Actions to work around a billing issue related to their beta.

The runners for dist-aarch64-apple were originally changed in 821b03d, and the aarch64-apple job was added in 6909992.

@rustbot

rustbot commented Jan 3, 2024

Copy link
Copy Markdown
Collaborator

r? @Kobzol

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 3, 2024
@jdno

jdno commented Jan 3, 2024

Copy link
Copy Markdown
MemberAuthor

I forgot to expand the YAML anchors. One second...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdno
jdnoforce-pushed the temporarily-disable-m1-runners branch from bb0851e to ea34c47CompareJanuary 3, 2024 14:14
@Kobzol

Kobzol commented Jan 3, 2024

Copy link
Copy Markdown
Member

Maybe we should just disable aarch64-apple, given that it was only enabled very recently (~2 months ago), and we're not sure if this modified configuration will work for it? But in any case, r=me, so that the tree can open ASAP.

@jdno

jdno commented Jan 3, 2024

Copy link
Copy Markdown
MemberAuthor

That's a good idea. Since this is only temporary, we should be fine skipping the tests for the moment.

@jdno
Temporarily disable M1 runners on GitHub Actions
0f9844d
This commit temporarily reverts the addition of M1 runners on GitHub
Actions to work around a billing issue related to their beta. It also
removes the `aarch64-apple` job, which was only added after the addition
of M1 runners. Since it has never been tested on the prior hardware, we
are skipping the tests to reduce the risk of build failures.
@jdno
jdnoforce-pushed the temporarily-disable-m1-runners branch from ea34c47 to 0f9844dCompareJanuary 3, 2024 14:21
@Kobzol

Kobzol commented Jan 3, 2024

Copy link
Copy Markdown
Member

@bors r+ rollup=never p=999

Let's see if this works.

@bors

bors commented Jan 3, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 0f9844d has been approved by Kobzol

It is now in the queue for this repository.

@bors

bors commented Jan 3, 2024

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2024
@bors

bors commented Jan 3, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 0f9844d with merge 2e79c8d...

@fmeasefmease mentioned this pull request Jan 3, 2024
Merged
@bors

bors commented Jan 3, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 2e79c8d to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 3, 2024
@bors
bors merged commit 2e79c8d into rust-lang:masterJan 3, 2024
@rustbotrustbot added this to the 1.77.0 milestone Jan 3, 2024
@rust-timer

rust-timer commented Jan 3, 2024

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (2e79c8d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 666.95s -> 668.218s (0.19%)
Artifact size: 311.74 MiB -> 311.73 MiB (-0.00%)

@dtolnaydtolnay mentioned this pull request Jan 4, 2024
Closed
This was referenced Jan 6, 2024
Closed
Closed
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jan 7, 2024
Merged
@Mark-SimulacrumMark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 7, 2024
@Mark-SimulacrumMark-Simulacrum removed this from the 1.77.0 milestone Jan 7, 2024
@Mark-SimulacrumMark-Simulacrum added this to the 1.76.0 milestone Jan 7, 2024
@Mark-Simulacrum

Mark-Simulacrum commented Jan 7, 2024

Copy link
Copy Markdown
Member

I've backported this to beta in #119719, we can revert that if this is fixed prior to the release.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 7, 2024
@bors
Auto merge ofrust-lang#119719- Mark-Simulacrum:beta-next, r=Mark-Si…
d05dd84
…mulacrum
[beta] backport rollup
This PR backports:
- rust-lang#119544: Fix: Properly set vendor in i686-win7-windows-msvc target
- rust-lang#118796: Exhaustiveness: Improve complexity on some wide matches
- rust-lang#119546: Temporarily disable M1 runners on GitHub Actions
- rust-lang#119584: [beta] Clippy (early) beta backport
- rust-lang#119559: [beta-1.76] Update cargo
And also:
- Bumps stage0 to released stable.
r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2024
@bors
Auto merge ofrust-lang#119719- Mark-Simulacrum:beta-next, r=Mark-Si…
650745c
…mulacrum
[beta] backport rollup
This PR backports:
- rust-lang#119544: Fix: Properly set vendor in i686-win7-windows-msvc target
- rust-lang#118796: Exhaustiveness: Improve complexity on some wide matches
- rust-lang#119546: Temporarily disable M1 runners on GitHub Actions
- rust-lang#119584: [beta] Clippy (early) beta backport
- rust-lang#119559: [beta-1.76] Update cargo
And also:
- Bumps stage0 to released stable.
r? `@Mark-Simulacrum`
@jdno
jdno deleted the temporarily-disable-m1-runners branch January 8, 2024 09:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@KobzolKobzol

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcbeta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jdno@rustbot@rust-log-analyzer@Kobzol@bors@rust-timer@Mark-Simulacrum