Uh oh!
There was an error while loading. Please reload this page.
Reorder early post-inlining passes. - #119677
Conversation
rustbot
commented
Jan 7, 2024
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
commented
Jan 7, 2024
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
This comment has been minimized.
This comment has been minimized.
petrochenkov
commented
Jan 7, 2024
r? compiler |
oli-obk
commented
Jan 8, 2024
@bors r+ rollup=never |
bors
commented
Jan 8, 2024
bors
commented
Jan 10, 2024
Reorder early post-inlining passes. `RemoveZsts`, `RemoveUnneededDrops` and `UninhabitedEnumBranching` only depend on types, so they should be executed together early after MIR inlining introduces those types. This does not change the end-result, but this makes the pipeline a bit more consistent.
bors
commented
Jan 10, 2024
💥 Test timed out |
rust-log-analyzer
commented
Jan 10, 2024
cjgillot
commented
Jan 10, 2024
@bors retry |
Reorder early post-inlining passes. `RemoveZsts`, `RemoveUnneededDrops` and `UninhabitedEnumBranching` only depend on types, so they should be executed together early after MIR inlining introduces those types. This does not change the end-result, but this makes the pipeline a bit more consistent.
bors
commented
Jan 10, 2024
rust-log-analyzer
commented
Jan 11, 2024
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Jan 11, 2024
💔 Test failed - checks-actions |
cjgillot
commented
Jan 11, 2024
@bors retry |
bors
commented
Jan 11, 2024
bors
commented
Jan 11, 2024
☀️ Test successful - checks-actions |
rust-timer
commented
Jan 11, 2024
Finished benchmarking commit (3a6bf35): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 668.141s -> 668.115s (-0.00%) |
RemoveZsts,RemoveUnneededDropsandUninhabitedEnumBranchingonly depend on types, so they should be executed together early after MIR inlining introduces those types.This does not change the end-result, but this makes the pipeline a bit more consistent.