Uh oh!
There was an error while loading. Please reload this page.
macro_rules: Add an expansion-local cache to span marker - #119693
Conversation
rustbot
commented
Jan 7, 2024
(rustbot has picked a reviewer for you, use r? to override) |
petrochenkov
commented
Jan 7, 2024
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
macro_rules: Add an expansion-local cache to span marker Most tokens in a macro body typically have the same syntax context. So the cache should usually be hit. This change can either be combined with rust-lang#119689, or serve as its alternative, depending on perf results.
bors
commented
Jan 7, 2024
bors
commented
Jan 7, 2024
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Jan 7, 2024
Finished benchmarking commit (44345bd): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 665.728s -> 666.41s (0.10%) |
cjgillot
commented
Jan 7, 2024
r=me with an in-code comment explaining why we need the local cache. |
petrochenkov
commented
Jan 8, 2024
@bors r=cjgillot |
bors
commented
Jan 8, 2024
bors
commented
Jan 8, 2024
bors
commented
Jan 8, 2024
☀️ Test successful - checks-actions |
rust-timer
commented
Jan 8, 2024
Finished benchmarking commit (0ee9cfd): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 666.019s -> 667.831s (0.27%) |
Kobzol
commented
Jan 8, 2024
The bit |
Most tokens in a macro body typically have the same syntax context.
So the cache should usually be hit.
This change can either be combined with #119689, or serve as its alternative, depending on perf results.