Skip to content

Merge dead bb pruning and unreachable bb deduplication. - #119699

Merged
bors merged 1 commit into
rust-lang:masterfrom
cjgillot:simplify-unreachable
Jan 9, 2024
Merged

Merge dead bb pruning and unreachable bb deduplication.#119699
bors merged 1 commit into
rust-lang:masterfrom
cjgillot:simplify-unreachable

Conversation

@cjgillot

@cjgillotcjgillot commented Jan 7, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Both routines share the same basic structure: iterate on all bbs to identify work, and then renumber bbs.

We can do both at once.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 7, 2024
@cjgillot

cjgillot commented Jan 7, 2024

Copy link
Copy Markdown
ContributorAuthor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 7, 2024
@bors

bors commented Jan 7, 2024

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 4071572 with merge 2fafef7...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 7, 2024
@bors
Auto merge ofrust-lang#119699- cjgillot:simplify-unreachable, r=<try>
2fafef7
Merge dead bb pruning and unreachable bb deduplication.
r? `@ghost`
@bors

bors commented Jan 7, 2024

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 2fafef7 (2fafef799934333509a6658f5f1ab643782c9de9)

@rust-timer

This comment has been minimized.

Sign in to view
@cjgillotcjgillot added the A-mir-opt Area: MIR optimizations label Jan 7, 2024
@rust-timer

rust-timer commented Jan 8, 2024

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (2fafef7): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		4.5%[1.9%, 10.6%]4
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-2.0%[-2.0%, -2.0%]1
All ❌✅ (primary)--0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		0.0%[0.0%, 0.0%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)0.0%[0.0%, 0.0%]1

Bootstrap: 665.728s -> 665.997s (0.04%)
Artifact size: 308.41 MiB -> 308.39 MiB (-0.01%)

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 8, 2024
@cjgillot
cjgillot marked this pull request as ready for review January 8, 2024 00:42
@rustbot

rustbot commented Jan 8, 2024

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@cjgillot

cjgillot commented Jan 8, 2024

Copy link
Copy Markdown
ContributorAuthor

r? compiler

@oli-obk

oli-obk commented Jan 8, 2024

Copy link
Copy Markdown
Contributor

r? @oli-obk
@bors r+

@bors

bors commented Jan 8, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 4071572 has been approved by oli-obk

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2024
@Noratrieb

Noratrieb commented Jan 9, 2024

Copy link
Copy Markdown
Member

perf neutral: @bors rollup=maybe

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 9, 2024
@GuillaumeGomez
Rollup merge ofrust-lang#119699- cjgillot:simplify-unreachable, r=o…
5ac5eb6
…li-obk
Merge dead bb pruning and unreachable bb deduplication.
Both routines share the same basic structure: iterate on all bbs to identify work, and then renumber bbs.
We can do both at once.
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jan 9, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2024
@bors
Auto merge ofrust-lang#119764- GuillaumeGomez:rollup-7jb3a5k, r=Gui…
a6f45a6
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#117372 (Update stdarch submodule)
- rust-lang#118241 (Making `User<T>` and `User<[T]>` `Send`)
- rust-lang#118748 (std: getrandom simplification for freebsd.)
- rust-lang#119527 (don't reexport atomic::ordering via rustc_data_structures, use std import)
- rust-lang#119699 (Merge dead bb pruning and unreachable bb deduplication.)
- rust-lang#119723 (Remove `-Zdont-buffer-diagnostics`.)
- rust-lang#119756 (rustdoc-search: reuse individual types in function signatures)
r? `@ghost`
`@rustbot` modify labels: rollup
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jan 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2024
@bors
Auto merge ofrust-lang#119767- GuillaumeGomez:rollup-fbp26yb, r=Gui…
13edaa3
…llaumeGomez
Rollup of 9 pull requests
Successful merges:
- rust-lang#117556 (Disallow reference to `static mut` and adding `static_mut_ref` lint)
- rust-lang#118748 (std: getrandom simplification for freebsd.)
- rust-lang#119282 (Rework and improve the unstable documentation of check-cfg)
- rust-lang#119527 (don't reexport atomic::ordering via rustc_data_structures, use std import)
- rust-lang#119668 (Simplify implementation of MIR promotion)
- rust-lang#119699 (Merge dead bb pruning and unreachable bb deduplication.)
- rust-lang#119723 (Remove `-Zdont-buffer-diagnostics`.)
- rust-lang#119756 (rustdoc-search: reuse individual types in function signatures)
- rust-lang#119758 (GNU/Hurd: unconditionally use inline stack probes)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2024
@bors
Auto merge ofrust-lang#119767- GuillaumeGomez:rollup-fbp26yb, r=Gui…
5876c8c
…llaumeGomez
Rollup of 9 pull requests
Successful merges:
- rust-lang#117556 (Disallow reference to `static mut` and adding `static_mut_ref` lint)
- rust-lang#118748 (std: getrandom simplification for freebsd.)
- rust-lang#119282 (Rework and improve the unstable documentation of check-cfg)
- rust-lang#119527 (don't reexport atomic::ordering via rustc_data_structures, use std import)
- rust-lang#119668 (Simplify implementation of MIR promotion)
- rust-lang#119699 (Merge dead bb pruning and unreachable bb deduplication.)
- rust-lang#119723 (Remove `-Zdont-buffer-diagnostics`.)
- rust-lang#119756 (rustdoc-search: reuse individual types in function signatures)
- rust-lang#119758 (GNU/Hurd: unconditionally use inline stack probes)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 9b90541 into rust-lang:masterJan 9, 2024
@rustbotrustbot added this to the 1.77.0 milestone Jan 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2024
@rust-timer
Unrolled build forrust-lang#119699
ce28c0c
Rollup merge of rust-lang#119699 - cjgillot:simplify-unreachable, r=oli-obk
Merge dead bb pruning and unreachable bb deduplication.
Both routines share the same basic structure: iterate on all bbs to identify work, and then renumber bbs.
We can do both at once.
@cjgillot
cjgillot deleted the simplify-unreachable branch January 9, 2024 18:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obkoli-obk

Labels

A-mir-optArea: MIR optimizationsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.77.0

Development

Successfully merging this pull request may close these issues.

7 participants

@cjgillot@rust-timer@bors@rustbot@oli-obk@Noratrieb@wesleywiser