Uh oh!
There was an error while loading. Please reload this page.
Fix two variable binding issues in lint let_underscore - #119704
Merged
Conversation
rustbot
commented
Jan 7, 2024
Collaborator
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
Noratrieb
approved these changes
Jan 7, 2024
Noratrieb
left a comment
Member
There was a problem hiding this comment.
If you think relying on default_binding_mode like this is fine, r=me. If you want to change it, then do that and I'll take another look.
| rustc_errors::SubdiagnosticMessage, | ||
| ) -> rustc_errors::SubdiagnosticMessage, | ||
| { | ||
| let prefix = if self.default_binding_mode { "" } else { "let " }; |
Member
There was a problem hiding this comment.
the comment on default_binding_mode says
At present, this is false only for destructuring assignment.
I don't like how that doesn't strongly imply that this truly is for destructuring assignment. This makes the code a bit harder to understand and potentially breaks in the future. I'm not sure what the nicest way to address this would be. If you agree.
This is also wrong and broken for non-trivial patterns like (_, _) = (Droppy, Droppy), but oh well, those don't even lint today, so Not Your Problem. I'm gonna try fixing these missing lints myself, so I think it's fine to merge this as-is.
MemberAuthor
There was a problem hiding this comment.
update the code to use assign_desugar, maybe a better choice?
MemberAuthor
There was a problem hiding this comment.
This pr seems forget to update comments for AssignDesugar
chenyukang@8cf3564
chenyukangforce-pushed
the
yukang-fix-let_underscore
branch
from
January 8, 2024 02:11
f2b97fd to
515bd25Compare| @@ -0,0 +1,21 @@ | |||
| // edition: 2021 | |||
Member
There was a problem hiding this comment.
there's a let_underscore_drop subdirectory, let's put it there
Noratrieb
approved these changes
Jan 8, 2024
Noratrieb
left a comment
Member
There was a problem hiding this comment.
that's nicer :)
r=me after moving the test
chenyukangforce-pushed
the
yukang-fix-let_underscore
branch
from
January 8, 2024 08:50
515bd25 to
75df38eComparechenyukang
commented
Jan 8, 2024
MemberAuthor
@bors r=Nilstrieb |
bors
commented
Jan 8, 2024
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 8, 2024
…re, r=Nilstrieb Fix two variable binding issues in lint let_underscore Fixesrust-lang#119696Fixesrust-lang#119697
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#118903 (Improved support of collapse_debuginfo attribute for macros.) - rust-lang#119033 (coverage: `llvm-cov` expects column numbers to be bytes, not code points) - rust-lang#119654 (bump bootstrap dependencies) - rust-lang#119660 (remove an unnecessary stderr-per-bitwidth) - rust-lang#119663 (tests: Normalize `\r\n` to `\n` in some run-make tests) - rust-lang#119681 (coverage: Anonymize line numbers in branch views) - rust-lang#119704 (Fix two variable binding issues in lint let_underscore) - rust-lang#119725 (Add helper for when we want to know if an item has a host param) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 8, 2024
…re, r=Nilstrieb Fix two variable binding issues in lint let_underscore Fixesrust-lang#119696Fixesrust-lang#119697
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 8, 2024
…re, r=Nilstrieb Fix two variable binding issues in lint let_underscore Fixesrust-lang#119696Fixesrust-lang#119697
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2024
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#116343 (Stop mentioning internal lang items in no_std binary errors) - rust-lang#118903 (Improved support of collapse_debuginfo attribute for macros.) - rust-lang#119033 (coverage: `llvm-cov` expects column numbers to be bytes, not code points) - rust-lang#119598 (Fix a typo in core::ops::Deref's doc) - rust-lang#119660 (remove an unnecessary stderr-per-bitwidth) - rust-lang#119663 (tests: Normalize `\r\n` to `\n` in some run-make tests) - rust-lang#119681 (coverage: Anonymize line numbers in branch views) - rust-lang#119704 (Fix two variable binding issues in lint let_underscore) - rust-lang#119725 (Add helper for when we want to know if an item has a host param) - rust-lang#119738 (Add `riscv32imafc-esp-espidf` tier 3 target for the ESP32-P4.) - rust-lang#119740 (Remove crossbeam-channel) Failed merges: - rust-lang#119723 (Remove `-Zdont-buffer-diagnostics`.) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#118903 (Improved support of collapse_debuginfo attribute for macros.) - rust-lang#119033 (coverage: `llvm-cov` expects column numbers to be bytes, not code points) - rust-lang#119598 (Fix a typo in core::ops::Deref's doc) - rust-lang#119660 (remove an unnecessary stderr-per-bitwidth) - rust-lang#119663 (tests: Normalize `\r\n` to `\n` in some run-make tests) - rust-lang#119681 (coverage: Anonymize line numbers in branch views) - rust-lang#119704 (Fix two variable binding issues in lint let_underscore) - rust-lang#119725 (Add helper for when we want to know if an item has a host param) - rust-lang#119738 (Add `riscv32imafc-esp-espidf` tier 3 target for the ESP32-P4.) - rust-lang#119740 (Remove crossbeam-channel) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2024
Rollup merge of rust-lang#119704 - chenyukang:yukang-fix-let_underscore, r=Nilstrieb Fix two variable binding issues in lint let_underscore Fixesrust-lang#119696Fixesrust-lang#119697
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 22, 2024
Improve `let_underscore_lock` - lint if the lock was in a nested pattern - lint if the lock is inside a `Result<Lock, _>` addresses rust-lang#119704 (comment)
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 22, 2024
Rollup merge of rust-lang#119710 - Nilstrieb:let-_-=-oops, r=TaKO8Ki Improve `let_underscore_lock` - lint if the lock was in a nested pattern - lint if the lock is inside a `Result<Lock, _>` addresses rust-lang#119704 (comment)
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Jan 25, 2024
Improve `let_underscore_lock` - lint if the lock was in a nested pattern - lint if the lock is inside a `Result<Lock, _>` addresses rust-lang/rust#119704 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#119696
Fixes#119697