Uh oh!
There was an error while loading. Please reload this page.
Taint _ placeholder types in trait impl method signatures - #119896
Merged
Conversation
oli-obk
marked this pull request as ready for review
January 12, 2024 16:35
rustbot
commented
Jan 12, 2024
Collaborator
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
oli-obk
commented
Jan 13, 2024
ContributorAuthor
@bors r=compiler-errors |
bors
commented
Jan 13, 2024
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 13, 2024
…rrors Taint `_` placeholder types in trait impl method signatures We report an error right below for them, but that kind of broken type can cause subsequent ICEs. fixesrust-lang#119867
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 13, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#119891 (rename `reported_signature_mismatch` to reflect its use) - rust-lang#119894 (Allow `~const` on associated type bounds again) - rust-lang#119896 (Taint `_` placeholder types in trait impl method signatures) - rust-lang#119898 (Remove unused `ErrorReporting` variant from overflow handling) - rust-lang#119902 (fix typo in `fn()` docs) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 13, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#119587 (Varargs support for system ABI) - rust-lang#119891 (rename `reported_signature_mismatch` to reflect its use) - rust-lang#119894 (Allow `~const` on associated type bounds again) - rust-lang#119896 (Taint `_` placeholder types in trait impl method signatures) - rust-lang#119898 (Remove unused `ErrorReporting` variant from overflow handling) - rust-lang#119902 (fix typo in `fn()` docs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 13, 2024
Rollup merge of rust-lang#119896 - oli-obk:variance_ice, r=compiler-errors Taint `_` placeholder types in trait impl method signatures We report an error right below for them, but that kind of broken type can cause subsequent ICEs. fixesrust-lang#119867
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We report an error right below for them, but that kind of broken type can cause subsequent ICEs.
fixes#119867