Rollup of 10 pull requests by fmease · Pull Request #120281 · rust-lang/rust

fmease · 2024-01-23T20:19:57Z

Successful merges:

Add more weirdness to weird-exprs.rs #119028 (Add more weirdness to weird-exprs.rs)
Suggest array::from_fn for array initialization #119805 (Suggest array::from_fn for array initialization)
compiler: update freebsd and netbsd base specs. #120188 (compiler: update freebsd and netbsd base specs.)
Update some deps with bitflags v1 dependencies #120215 (Update some deps with bitflags v1 dependencies)
Use Self in NonZero* implementations. #120244 (Use Self in NonZero* implementations.)
Re-add estebank to review rotation #120246 (Re-add estebank to review rotation)
rename RawTy to LoweredTy #120252 (rename RawTy to LoweredTy)
correct my mailmap entry #120255 (correct my mailmap entry)
A bunch of random modifications #120270 (A bunch of random modifications)
Move condition enabling the pass to is_enabled #120280 (Move condition enabling the pass to is_enabled)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

both support thread local.

The practical motivation is to omit the pass from -Zdump-mir=all when disabled.

Add more weirdness to weird-exprs.rs

…vidtwco Suggest array::from_fn for array initialization Fixesrust-lang#119530

…specs, r=wesleywiser compiler: update freebsd and netbsd base specs. both support thread local.

Update some deps with `bitflags` v1 dependencies This only leaves `pulldown-cmark` (which has updated to bitflags v2 in Git) and `rustc_apfloat` (PR opened previously at rust-lang/rustc_apfloat#12)

Use `Self` in `NonZero*` implementations. This slightly reduces the size of the eventual diff when making these generic, since this can be merged independently.

…estebank Re-add estebank to review rotation r? ``@compiler-errors``

…-errors rename `RawTy` to `LoweredTy` I believe this name to more closely match its purpose r? ``@compiler-errors``

correct my mailmap entry

A bunch of random modifications r? oli-obk Kitchen sink of changes that I didn't know where to put elsewhere. Documentation tweaks mostly, but also removing some unreachable code and simplifying the pretty printing for closures/coroutines.

Move condition enabling the pass to `is_enabled` The practical motivation is to omit the pass from -Zdump-mir=all when disabled.

fmease · 2024-01-23T20:20:17Z

@bors r+ rollup=never p=10

bors · 2024-01-23T20:20:19Z

📌 Commit 08bac31 has been approved by fmease

It is now in the queue for this repository.

bors · 2024-01-23T20:43:41Z

⌛ Testing commit 08bac31 with merge 5d3d347...

bors · 2024-01-23T22:43:00Z

☀️ Test successful - checks-actions
Approved by: fmease
Pushing 5d3d347 to master...

rust-timer · 2024-01-23T22:45:48Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#119028	Add more weirdness to weird-exprs.rs	`b324b37c4825e038fd8746525964906dabfb3ab6` (link)
#119805	Suggest array::from_fn for array initialization	`f0c1c3f44ec07aa80f4663e887d3f4b37e4bf71d` (link)
#120188	compiler: update freebsd and netbsd base specs.	`e57847bbfcd7976f9468c117b0b68b2a47242c40` (link)
#120215	Update some deps with `bitflags` v1 dependencies	`209f1455f6dff6be772185a0903ed46922672ecf` (link)
#120244	Use `Self` in `NonZero*` implementations.	`77401ed238603772e6ef3324ba69bc31426d0433` (link)
#120246	Re-add estebank to review rotation	`06f1a43a9ba1037eb2154fa1a7b9814f5b865f9c` (link)
#120252	rename `RawTy` to `LoweredTy`	`c8aafb8378b83891481a0ff970bce9f8b8664365` (link)
#120255	correct my mailmap entry	`17ef1e68a397108c0ee3bf2d923c6535c6a0dd84` (link)
#120270	A bunch of random modifications	`231695f0bc4a263294494a8ae03fca5e121b64ba` (link)
#120280	Move condition enabling the pass to `is_enabled`	`92e5ec7d14d9dfb69591458a9683cb21e544e47f` (link)

previous master: dfe53afaeb

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-01-23T23:59:08Z

Finished benchmarking commit (5d3d347): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-3.5%, -3.5%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	8.3%	[6.5%, 10.5%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 662.823s -> 664.053s (0.19%)
Artifact size: 308.32 MiB -> 308.29 MiB (-0.01%)

oberienand others added 23 commits December 16, 2023 23:44

Add more weirdness to weird-exprs.rs
2d1b2a9

Suggest arry::from_fn for array initialization
3ed96e3

Rename function in weird-exprs.rs for clarity
98f5981

Bump ctrlc version
527f903

Bump openssl version
c751720

correct my mailmap entry
7a17508

compiler: update freebsd and netbsd base specs.
dec4740
both support thread local.

Use Self in NonZero* implementations.
a77cc2c

Re-add estebank to review rotation
ce11b70

fixing build for the BSD
ed4b99a

RawTy to LoweredTy
c6088f7

Random type checker changes
5fc39e0

Move condition enabling the pass to is_enabled
c8e4aaa
The practical motivation is to omit the pass from -Zdump-mir=all when disabled.

Rollup merge ofrust-lang#119028- oberien:patch-1, r=cjgillot
e8f9e54
Add more weirdness to weird-exprs.rs

Rollup merge ofrust-lang#119805- chenyukang:yukang-fix-119530, r=da…
dd538b5
…vidtwco Suggest array::from_fn for array initialization Fixesrust-lang#119530

Rollup merge ofrust-lang#120188- devnexen:update_bsd_compiler_base_…
1e5ec4d
…specs, r=wesleywiser compiler: update freebsd and netbsd base specs. both support thread local.

Rollup merge ofrust-lang#120215- clubby789:dep-updates, r=Nilstrieb
09c31b8
Update some deps with `bitflags` v1 dependencies This only leaves `pulldown-cmark` (which has updated to bitflags v2 in Git) and `rustc_apfloat` (PR opened previously at rust-lang/rustc_apfloat#12)

Rollup merge ofrust-lang#120244- reitermarkus:nonzero-self, r=dtolnay
8fea4a8
Use `Self` in `NonZero*` implementations. This slightly reduces the size of the eventual diff when making these generic, since this can be merged independently.

Rollup merge ofrust-lang#120246- estebank:revert_breathing_room, r=…
0d3af59
…estebank Re-add estebank to review rotation r? ``@compiler-errors``

Rollup merge ofrust-lang#120252- lcnr:rename-astconv-ty, r=compiler…
0c769cc
…-errors rename `RawTy` to `LoweredTy` I believe this name to more closely match its purpose r? ``@compiler-errors``

Rollup merge ofrust-lang#120255- emberian:patch-1, r=Nilstrieb
456974b
correct my mailmap entry

Rollup merge ofrust-lang#120280- tmiasko:is-enabled, r=compiler-errors
08bac31
Move condition enabling the pass to `is_enabled` The practical motivation is to omit the pass from -Zdump-mir=all when disabled.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 23, 2024

bors merged commit 5d3d347 into rust-lang:masterJan 23, 2024

rustbot added this to the 1.77.0 milestone Jan 23, 2024

fmease deleted the rollup-9nxail8 branch January 23, 2024 22:45

Navigation Menu

Uh oh!

Uh oh!

Rollup of 10 pull requests - #120281

Rollup of 10 pull requests#120281
bors merged 23 commits into
rust-lang:masterfrom
fmease:rollup-9nxail8

fmease commented Jan 23, 2024

Uh oh!

fmease commented Jan 23, 2024

Uh oh!

bors commented Jan 23, 2024

Uh oh!

bors commented Jan 23, 2024

Uh oh!

bors commented Jan 23, 2024

Uh oh!

rust-timer commented Jan 23, 2024

Uh oh!

rust-timer commented Jan 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Uh oh!

Uh oh!

Conversation

fmease commented Jan 23, 2024

Uh oh!

fmease commented Jan 23, 2024

Uh oh!

bors commented Jan 23, 2024

Uh oh!

bors commented Jan 23, 2024

Uh oh!

bors commented Jan 23, 2024

Uh oh!

rust-timer commented Jan 23, 2024

Uh oh!

rust-timer commented Jan 23, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants