Uh oh!
There was an error while loading. Please reload this page.
Fix ICE on field access on a tainted type after const-eval failure - #120616
Merged
bors merged 1 commit intoFeb 4, 2024
Merged
Conversation
fmease
commented
Feb 3, 2024
Uh oh!
There was an error while loading. Please reload this page.
fmease
marked this pull request as draft
February 3, 2024 16:48
fmeaseforce-pushed
the
fix-ice-const-eval-fail-undef-field-access
branch
from
February 3, 2024 18:36
f39b6fd to
2668fa6Comparefmease
marked this pull request as ready for review
February 3, 2024 18:37
fmeaseforce-pushed
the
fix-ice-const-eval-fail-undef-field-access
branch
from
February 3, 2024 18:40
2668fa6 to
0f31749CompareCo-authored-by: Michael Goulet <michael@errs.io>
fmeaseforce-pushed
the
fix-ice-const-eval-fail-undef-field-access
branch
from
February 3, 2024 18:41
0f31749 to
4f773afComparecompiler-errors
approved these changes
Feb 3, 2024
compiler-errors
commented
Feb 3, 2024
Contributor
@bors r+ rollup |
bors
commented
Feb 3, 2024
Collaborator
bors
commented
Feb 3, 2024
Collaborator
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 4, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#119543 (add avx512fp16 to x86 target features) - rust-lang#120004 (Release notes for 1.76) - rust-lang#120562 (Revert unsound libcore changes) - rust-lang#120566 (coverage: Use normal `edition:` headers in coverage tests) - rust-lang#120570 (Suggest changing type to const parameters if we encounter a type in the trait bound position) - rust-lang#120571 (Miscellaneous diagnostics cleanups) - rust-lang#120573 (Remove `BorrowckErrors::tainted_by_errors`) - rust-lang#120592 (Remove unnecessary `.to_string()`/`.as_str()`s) - rust-lang#120610 (hir: Remove the generic type parameter from `MaybeOwned`) - rust-lang#120616 (Fix ICE on field access on a tainted type after const-eval failure) Failed merges: - rust-lang#120569 (coverage: Improve handling of function/closure spans) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 4, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#119543 (add avx512fp16 to x86 target features) - rust-lang#120004 (Release notes for 1.76) - rust-lang#120562 (Revert unsound libcore changes) - rust-lang#120566 (coverage: Use normal `edition:` headers in coverage tests) - rust-lang#120570 (Suggest changing type to const parameters if we encounter a type in the trait bound position) - rust-lang#120571 (Miscellaneous diagnostics cleanups) - rust-lang#120573 (Remove `BorrowckErrors::tainted_by_errors`) - rust-lang#120592 (Remove unnecessary `.to_string()`/`.as_str()`s) - rust-lang#120610 (hir: Remove the generic type parameter from `MaybeOwned`) - rust-lang#120616 (Fix ICE on field access on a tainted type after const-eval failure) Failed merges: - rust-lang#120569 (coverage: Improve handling of function/closure spans) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 4, 2024
Rollup merge of rust-lang#120616 - fmease:fix-ice-const-eval-fail-undef-field-access, r=compiler-errors Fix ICE on field access on a tainted type after const-eval failure Fixesrust-lang#120615. r? oli-obk or compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#120615.
r? oli-obk or compiler