Skip to content

Add parallel rustc ui tests - #120664

Merged
bors merged 1 commit into
rust-lang:masterfrom
SparrowLii:parallel_test
Feb 7, 2024
Merged

Add parallel rustc ui tests#120664
bors merged 1 commit into
rust-lang:masterfrom
SparrowLii:parallel_test

Conversation

@SparrowLii

@SparrowLiiSparrowLii commented Feb 5, 2024

Copy link
Copy Markdown
Member

Updates #118698

Add some ui tests for parallel rustc front end

This is a relatively large feature so I think it's worth creating a new entity in tests/ui folder, so we need to modify the limit in tidy.

@rustbot

rustbot commented Feb 5, 2024

Copy link
Copy Markdown
Collaborator

r? @michaelwoerister

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 5, 2024
@michaelwoerister

michaelwoerister commented Feb 5, 2024

Copy link
Copy Markdown
Member

Thanks for the PR, @SparrowLii!

It looks like we don't have a parallelization group in triagebot.toml. Do you know a reviewer with the necessary context?

@SparrowLii

SparrowLii commented Feb 5, 2024

Copy link
Copy Markdown
MemberAuthor

ok
r? @nnethercote
cc @cjgillot@bjorn3@Kobzol

@matthiaskrgr

matthiaskrgr commented Feb 5, 2024•
edited
Loading

Copy link
Copy Markdown
Member

How will we deal with spurious failures of these in CI that only happen every 10th/100th run or so?

@SparrowLii

SparrowLii commented Feb 5, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Some use cases can be tested multiple times (such as 10 or 100 times) by modifying the compile-test tool, but there are still some errors (such as once in 10000 times) that are difficult to guarantee correct.

So I think this PR is just the beginning

@matthiaskrgr

matthiaskrgr commented Feb 5, 2024

Copy link
Copy Markdown
Member

Maybe we can also increase the threadcount to 50 or so to increase the chance of concurrency problems?

@SparrowLii

SparrowLii commented Feb 5, 2024

Copy link
Copy Markdown
MemberAuthor

Yeah of course we should.

We can add some simple use cases first to ensure that the basic functions will not be overturned (such as #118648)

Noratrieb
Noratrieb reviewed Feb 5, 2024
View reviewed changes
Comment threadtests/ui/parallel-rustc/hello_world.rs
Comment threadtests/ui/parallel-rustc/issue-111520.rs
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@SparrowLii

SparrowLii commented Feb 5, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

The no ImplicitCtxt stored in tls error showed here so I think we need to solve #111522 first :(

Otherwise we cannot guarantee the stability of the test results

The reason for this error is that the test case workerlocal-outer-thread-pool-issue-94654.rs relies on the deadlock_handler function (since it has queries cycle error), which triggers the error in #111522. Other test cases should not be affected.

@nnethercote

nnethercote commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

I think the commits should be squashed together before merging. Otherwise, more tests is good. It seems like the concern from yesterday has been resolved? If so, r=me once the commits are squashed.

@SparrowLii

SparrowLii commented Feb 7, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks! We need to enhance the ui testing tool to support more tests (I listed it in #118698), so I would like to add them in another new PR

@SparrowLii

SparrowLii commented Feb 7, 2024

Copy link
Copy Markdown
MemberAuthor

@bors r=nnethercote

@bors

bors commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 073f5cd has been approved by nnethercote

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2024
@bors

bors commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #120722) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2024
@SparrowLii

SparrowLii commented Feb 7, 2024

Copy link
Copy Markdown
MemberAuthor

@bors r=nnethercote

@bors

bors commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit a59d006 has been approved by nnethercote

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 7, 2024
Nadrieril added a commit to Nadrieril/rust that referenced this pull request Feb 7, 2024
@Nadrieril
Rollup merge ofrust-lang#120664- SparrowLii:parallel_test, r=nnethe…
8ba999e
…rcote
Add parallel rustc ui tests
Updates rust-lang#118698
Add some ui tests for parallel rustc front end
This is a relatively large feature so I think it's worth creating a new entity in tests/ui folder, so we need to modify the limit in tidy.
@NadrierilNadrieril mentioned this pull request Feb 7, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2024
@bors
Auto merge ofrust-lang#120743- Nadrieril:rollup-h2mxjc2, r=Nadrieril
e8ec9f4
Rollup of 13 pull requests
Successful merges:
- rust-lang#110482 (Add armv8r-none-eabihf target for the Cortex-R52.)
- rust-lang#119162 (Add unstable `-Z direct-access-external-data` cmdline flag for `rustc`)
- rust-lang#120302 (various const interning cleanups)
- rust-lang#120455 ( Add FileCheck annotations to MIR-opt SROA tests)
- rust-lang#120470 (Mark "unused binding" suggestion as maybe incorrect)
- rust-lang#120479 (Suggest turning `if let` into irrefutable `let` if appropriate)
- rust-lang#120564 (coverage: Split out counter increment sites from BCB node/edge counters)
- rust-lang#120633 (pattern_analysis: gather up place-relevant info)
- rust-lang#120664 (Add parallel rustc ui tests)
- rust-lang#120721 (fix `llvm_out` to use the correct LLVM root)
- rust-lang#120726 (Don't use bashism in checktools.sh)
- rust-lang#120733 (MirPass: make name more const)
- rust-lang#120735 (Remove some `unchecked_claim_error_was_emitted` calls)
Failed merges:
- rust-lang#120727 (exhaustiveness: Prefer "`0..MAX` not covered" to "`_` not covered")
r? `@ghost`
`@rustbot` modify labels: rollup
@NadrierilNadrieril mentioned this pull request Feb 7, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2024
@bors
Auto merge ofrust-lang#120748- Nadrieril:rollup-dj0qwv5, r=Nadrieril
8ace7ea
Rollup of 13 pull requests
Successful merges:
- rust-lang#110482 (Add armv8r-none-eabihf target for the Cortex-R52.)
- rust-lang#119162 (Add unstable `-Z direct-access-external-data` cmdline flag for `rustc`)
- rust-lang#120302 (various const interning cleanups)
- rust-lang#120455 ( Add FileCheck annotations to MIR-opt SROA tests)
- rust-lang#120470 (Mark "unused binding" suggestion as maybe incorrect)
- rust-lang#120479 (Suggest turning `if let` into irrefutable `let` if appropriate)
- rust-lang#120564 (coverage: Split out counter increment sites from BCB node/edge counters)
- rust-lang#120633 (pattern_analysis: gather up place-relevant info)
- rust-lang#120664 (Add parallel rustc ui tests)
- rust-lang#120726 (Don't use bashism in checktools.sh)
- rust-lang#120733 (MirPass: make name more const)
- rust-lang#120735 (Remove some `unchecked_claim_error_was_emitted` calls)
- rust-lang#120746 (Record coroutine kind in coroutine generics)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit eecab31 into rust-lang:masterFeb 7, 2024
@rustbotrustbot added this to the 1.78.0 milestone Feb 7, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2024
@rust-timer
Unrolled build forrust-lang#120664
50dbec4
Rollup merge of rust-lang#120664 - SparrowLii:parallel_test, r=nnethercote
Add parallel rustc ui tests
Updates rust-lang#118698
Add some ui tests for parallel rustc front end
This is a relatively large feature so I think it's worth creating a new entity in tests/ui folder, so we need to modify the limit in tidy.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoratriebNoratriebNoratrieb left review comments

Assignees

@nnethercotennethercote

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.78.0

Development

Successfully merging this pull request may close these issues.

8 participants

@SparrowLii@rustbot@michaelwoerister@matthiaskrgr@rust-log-analyzer@nnethercote@bors@Noratrieb