Skip to content

std::thread update freebsd stack guard handling. - #120672

Merged
bors merged 1 commit into
rust-lang:masterfrom
devnexen:update_thread_stack_guardpages_fbsd
Feb 15, 2024
Merged

std::thread update freebsd stack guard handling.#120672
bors merged 1 commit into
rust-lang:masterfrom
devnexen:update_thread_stack_guardpages_fbsd

Conversation

@devnexen

Copy link
Copy Markdown
Contributor

up to now, it had been assumed the stack guard setting default is not touched in the field but some user might just want to disable it or increase it. checking it once at runtime should be enough.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 5, 2024
@rust-log-analyzer

This comment has been minimized.

@devnexen
devnexenforce-pushed the update_thread_stack_guardpages_fbsd branch from 777b719 to 591b642CompareFebruary 5, 2024 11:28
Comment threadlibrary/std/src/sys/pal/unix/thread.rs Outdated
@devnexen
devnexenforce-pushed the update_thread_stack_guardpages_fbsd branch from 591b642 to ff3fd6aCompareFebruary 5, 2024 13:12
@workingjubilee

Copy link
Copy Markdown
Member

@devnexen It can be disabled? Really?

@devnexen

Copy link
Copy Markdown
ContributorAuthor

Yes :)

@m-ou-se

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Feb 8, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit ff3fd6a has been approved by m-ou-se

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2024
@NadrierilNadrieril changed the title std::thread update freensd stack guard handling.std::thread update freebsd stack guard handling.Feb 8, 2024
@Nadrieril

Copy link
Copy Markdown
Member

@bors rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 9, 2024
…pages_fbsd, r=m-ou-se
std::thread update freebsd stack guard handling.
up to now, it had been assumed the stack guard setting default is not touched in the field but some user might just want to disable it or increase it. checking it once at runtime should be enough.
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2024
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#120308 (core/time: avoid divisions in Duration::new)
- rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version)
- rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages)
- rust-lang#120672 (std::thread update freebsd stack guard handling.)
- rust-lang#120693 (Invert diagnostic lints.)
- rust-lang#120704 (A drive-by rewrite of `give_region_a_name()`)
- rust-lang#120806 (Clippy subtree update)
- rust-lang#120809 (Use `transmute_unchecked` in `NonZero::new`.)
- rust-lang#120817 (Fix more `ty::Error` ICEs in MIR passes)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr

Copy link
Copy Markdown
Member

@bors r-
failed here I think #120824 (comment)

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 9, 2024
@devnexen
devnexenforce-pushed the update_thread_stack_guardpages_fbsd branch from ff3fd6a to f6868afCompareFebruary 9, 2024 19:25
up to now, it had been assumed the stack guard setting default is not
touched in the field but some user might just want to disable it or
increase it. checking it once at runtime should be enough.
@devnexen
devnexenforce-pushed the update_thread_stack_guardpages_fbsd branch from f6868af to 6686ca0CompareFebruary 9, 2024 20:12
@devnexen

devnexen commented Feb 9, 2024

Copy link
Copy Markdown
ContributorAuthor

@rustbot review

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 9, 2024
@m-ou-se

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Feb 15, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 6686ca0 has been approved by m-ou-se

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2024
…llaumeGomez
Rollup of 8 pull requests
Successful merges:
- rust-lang#120449 (Document requirements for unsized {Rc,Arc}::from_raw)
- rust-lang#120505 (Fix BTreeMap's Cursor::remove_{next,prev})
- rust-lang#120672 (std::thread update freebsd stack guard handling.)
- rust-lang#121088 (Implicitly enable evex512 if avx512 is enabled)
- rust-lang#121104 (Ignore unsized types when trying to determine the size of the original type)
- rust-lang#121107 (Fix msg for verbose suggestions with confusable capitalization)
- rust-lang#121113 (Continue compilation even if inherent impl checks fail)
- rust-lang#121120 (Add `ErrorGuaranteed` to `ast::LitKind::Err`, `token::LitKind::Err`.)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit bf323ba into rust-lang:masterFeb 15, 2024
@rustbotrustbot added this to the 1.78.0 milestone Feb 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2024
Rollup merge of rust-lang#120672 - devnexen:update_thread_stack_guardpages_fbsd, r=m-ou-se
std::thread update freebsd stack guard handling.
up to now, it had been assumed the stack guard setting default is not touched in the field but some user might just want to disable it or increase it. checking it once at runtime should be enough.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-unixOperating system: Unix-likeS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@devnexen@rustbot@rust-log-analyzer@workingjubilee@m-ou-se@bors@Nadrieril@matthiaskrgr@joboet