Uh oh!
There was an error while loading. Please reload this page.
Implement List's any function - #12132
Closed
brunoabinader wants to merge 1 commit into
Closed
Conversation
alexcrichton
commented
Feb 9, 2014
Member
Here's some thoughts that I have on this:
It sounds like this module needs to be rewritten completely, but I don't think that should be done as part of this PR. I'd be comfortable with merging if this had a test checked in. |
lilyball
commented
Feb 9, 2014
Contributor
I would suggest this function be renamed to |
brunoabinader
commented
Feb 9, 2014
ContributorAuthor
Thanks for the review! I've updated the patch with the following:
|
This is needed for cases where we only need to know if a list item matches the given predicate (eg. in Servo, we need to know if attributes from different DOM elements are equal).
brunoabinader
commented
Feb 10, 2014
ContributorAuthor
Hi @alexcrichton, I've updated the patch again with a typo fix in the test that appeared in the last minute. |
bors added a commit
that referenced
this pull request
Feb 10, 2014
…lexcrichton This is needed for cases where we only need to know if a list item matches the given predicate (eg. in Servo, we need to know if attributes from different DOM elements are equal).
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 25, 2024
…dnet I'm not on vacation (again) A few weeks ago I opened rust-lang#12011 removing me from `users_on_vacation`, it got merged. The subtree sync reverted this change (weirdly) changelog: none r? `@xFrednet`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for cases where we only need to know if a list item matches the given predicate (eg. in Servo, we need to know if attributes from different DOM elements are equal).