Skip to content

Remove some dead code - #122028

Merged
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:drop_in_place_leftovers
Mar 6, 2024
Merged

Remove some dead code#122028
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:drop_in_place_leftovers

Conversation

@oli-obk

Copy link
Copy Markdown
Contributor

drop_in_place has been a lang item, not an intrinsic, for forever

drop_in_place has been a lang item, not an intrinsic, for forever
@rustbot

Copy link
Copy Markdown
Collaborator

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 5, 2024
@compiler-errors

Copy link
Copy Markdown
Contributor

thank u r? compiler-errors @bors r+ rollup

@bors

bors commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 5a16aeb has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 5, 2024
…=compiler-errors
Remove some dead code
drop_in_place has been a lang item, not an intrinsic, for forever
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 5, 2024
…=compiler-errors
Remove some dead code
drop_in_place has been a lang item, not an intrinsic, for forever
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 5, 2024
…=compiler-errors
Remove some dead code
drop_in_place has been a lang item, not an intrinsic, for forever
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2024
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#121065 (Add basic i18n guidance for `Display`)
- rust-lang#121301 (errors: share `SilentEmitter` between rustc and rustfmt)
- rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrate check)
- rust-lang#121829 (Dummy tweaks (attempt 2))
- rust-lang#121857 (Implement async closure signature deduction)
- rust-lang#121894 (const_eval_select: make it safe but be careful with what we expose on stable for now)
- rust-lang#121905 (Add a `description` field to target definitions)
- rust-lang#122022 (loongarch: add frecipe and relax target feature)
- rust-lang#122028 (Remove some dead code)
r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 5, 2024
…=compiler-errors
Remove some dead code
drop_in_place has been a lang item, not an intrinsic, for forever
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2024
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#121065 (Add basic i18n guidance for `Display`)
- rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrate check)
- rust-lang#121829 (Dummy tweaks (attempt 2))
- rust-lang#121832 (Add new Tier-3 target: `loongarch64-unknown-linux-musl`)
- rust-lang#121857 (Implement async closure signature deduction)
- rust-lang#121894 (const_eval_select: make it safe but be careful with what we expose on stable for now)
- rust-lang#122014 (Change some attributes to only_local.)
- rust-lang#122016 (will_wake tests fail on Miri and that is expected)
- rust-lang#122018 (only set noalias on Box with the global allocator)
- rust-lang#122028 (Remove some dead code)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2024
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#121065 (Add basic i18n guidance for `Display`)
- rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrate check)
- rust-lang#121829 (Dummy tweaks (attempt 2))
- rust-lang#121857 (Implement async closure signature deduction)
- rust-lang#121894 (const_eval_select: make it safe but be careful with what we expose on stable for now)
- rust-lang#122014 (Change some attributes to only_local.)
- rust-lang#122016 (will_wake tests fail on Miri and that is expected)
- rust-lang#122018 (only set noalias on Box with the global allocator)
- rust-lang#122028 (Remove some dead code)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2024
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#121065 (Add basic i18n guidance for `Display`)
- rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrate check)
- rust-lang#121829 (Dummy tweaks (attempt 2))
- rust-lang#121857 (Implement async closure signature deduction)
- rust-lang#121894 (const_eval_select: make it safe but be careful with what we expose on stable for now)
- rust-lang#122014 (Change some attributes to only_local.)
- rust-lang#122016 (will_wake tests fail on Miri and that is expected)
- rust-lang#122018 (only set noalias on Box with the global allocator)
- rust-lang#122028 (Remove some dead code)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 4f73d2a into rust-lang:masterMar 6, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2024
Rollup merge of rust-lang#122028 - oli-obk:drop_in_place_leftovers, r=compiler-errors
Remove some dead code
drop_in_place has been a lang item, not an intrinsic, for forever
@rustbotrustbot added this to the 1.78.0 milestone Mar 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@oli-obk@rustbot@compiler-errors@bors@cjgillot