Uh oh!
There was an error while loading. Please reload this page.
Add consistency with phrases "meantime" and "mean time" - #122807
Merged
Conversation
rustbot
commented
Mar 21, 2024
Collaborator
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
commented
Mar 21, 2024
Collaborator
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
davidtwco
approved these changes
Mar 24, 2024
davidtwco
left a comment
Member
There was a problem hiding this comment.
r=me after you revert the unrelated code format changes
danielhuang
commented
Apr 3, 2024
ContributorAuthor
Removed unnecessary changes; they were put there by rustfmt. |
davidtwco
commented
Apr 8, 2024
Member
@bors r+ rollup |
bors
commented
Apr 8, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 8, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#115984 (extending filesystem support for Hermit) - rust-lang#120144 (privacy: Stabilize lint `unnameable_types`) - rust-lang#122807 (Add consistency with phrases "meantime" and "mean time") - rust-lang#123089 (Add invariant to VecDeque::pop_* that len < cap if pop successful) - rust-lang#123595 (Documentation fix) - rust-lang#123625 (Stop exporting `TypeckRootCtxt` and `FnCtxt`.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 8, 2024
Rollup merge of rust-lang#122807 - danielhuang:fix-1, r=davidtwco Add consistency with phrases "meantime" and "mean time" "mean time" is used in a few places while "meantime" is used everywhere else; this would make usage consistent throughout the codebase.
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 18, 2024
Add consistency with phrases "meantime" and "mean time" "mean time" is used in a few places while "meantime" is used everywhere else; this would make usage consistent throughout the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"mean time" is used in a few places while "meantime" is used everywhere else; this would make usage consistent throughout the codebase.