Fix incorrect suggestion for undeclared hrtb lifetimes in where clauses. by surechen · Pull Request #123122 · rust-lang/rust

surechen · 2024-03-27T04:43:07Z

For poly-trait-ref like for<'a> Trait<T> in T: for<'a> Trait<T> + 'b { }.
We should merge the hrtb lifetimes: existed for<'a> and suggestion for<'b> or will get err: [E0316] nested quantification of lifetimes

fixes#122714

rustbot · 2024-03-27T04:43:14Z

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

oli-obk · 2024-04-09T13:24:50Z

r? @fmease

fmease

Apologies for the delay! I've potentially found some smaller issues. Furthermore, I'm not super convinced by the current approach which adds an entirely new field to the resolver just to fix a niche diagnostic bug. I go into more detail in some of my review comments.

surechen · 2024-04-24T01:53:26Z

Apologies for the delay! I've potentially found some smaller issues. Furthermore, I'm not super convinced by the current approach which adds an entirely new field to the resolver just to fix a niche diagnostic bug. I go into more detail in some of my review comments.

Thank you very much. Your review is very detailed and helps me a lot. I will spend some time processing it.

fmease

Thanks a lot, that looks great! ❤️ I apologize for taking so long (yet again!) 😞.

Almost ready, I have a couple of small suggestions. Then I will put into the merge queue!

fixesrust-lang#122714

surechen · 2024-05-21T01:23:40Z

Thanks a lot, that looks great! ❤️ I apologize for taking so long (yet again!) 😞.
Almost ready, I have a couple of small suggestions. Then I will put into the merge queue!

Thank you very much. Please help me review again.

fmease

Thanks a lot!

fmease · 2024-05-21T11:24:28Z

@bors r+ rollup

bors · 2024-05-21T11:24:30Z

📌 Commit 4ebbb5f has been approved by fmease

It is now in the queue for this repository.

Fix incorrect suggestion for undeclared hrtb lifetimes in where clauses. For poly-trait-ref like `for<'a> Trait<T>` in `T: for<'a> Trait<T> + 'b { }`. We should merge the hrtb lifetimes: existed `for<'a>` and suggestion `for<'b>` or will get err: [E0316] nested quantification of lifetimes fixesrust-lang#122714

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#122665 (Add some tests for public-private dependencies.) - rust-lang#123122 (Fix incorrect suggestion for undeclared hrtb lifetimes in where clauses.) - rust-lang#125276 (Fix parsing of erroneously placed semicolons) - rust-lang#125310 (Move ~100 tests from tests/ui to subdirs) - rust-lang#125357 (Migrate `run-make/rustdoc-scrape-examples-multiple` to `rmake.rs`) - rust-lang#125369 (Don't do cc detection for synthetic targets) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#123122 (Fix incorrect suggestion for undeclared hrtb lifetimes in where clauses.) - rust-lang#123492 (add pull request template asking for relevant tracking issues) - rust-lang#125276 (Fix parsing of erroneously placed semicolons) - rust-lang#125310 (Move ~100 tests from tests/ui to subdirs) - rust-lang#125357 (Migrate `run-make/rustdoc-scrape-examples-multiple` to `rmake.rs`) - rust-lang#125369 (Don't do cc detection for synthetic targets) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#123122 - surechen:fix_122714, r=fmease Fix incorrect suggestion for undeclared hrtb lifetimes in where clauses. For poly-trait-ref like `for<'a> Trait<T>` in `T: for<'a> Trait<T> + 'b { }`. We should merge the hrtb lifetimes: existed `for<'a>` and suggestion `for<'b>` or will get err: [E0316] nested quantification of lifetimes fixesrust-lang#122714

rustbot assigned oli-obk Mar 27, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 27, 2024

surechen force-pushed the fix_122714 branch from b186d4c to c864852Compare March 27, 2024 04:50

fmease reviewed Mar 28, 2024
View reviewed changes

Comment threadcompiler/rustc_resolve/src/late.rs Outdated
Comment threadcompiler/rustc_resolve/src/late/diagnostics.rs Outdated

surechen force-pushed the fix_122714 branch 2 times, most recently from 2941db4 to db9b023Compare March 28, 2024 07:22

surechen requested a review from fmease March 28, 2024 11:41

fmease assigned fmease and unassigned oli-obk Apr 7, 2024

oli-obk reviewed Apr 8, 2024
View reviewed changes

Comment threadcompiler/rustc_resolve/src/late.rs Outdated
Comment threadcompiler/rustc_resolve/src/late/diagnostics.rs Outdated

fmease assigned oli-obk and unassigned fmease Apr 8, 2024

surechen force-pushed the fix_122714 branch from db9b023 to e704d5fCompare April 9, 2024 10:53

surechen requested a review from oli-obk April 9, 2024 10:57

oli-obk reviewed Apr 9, 2024
View reviewed changes

Comment threadcompiler/rustc_resolve/src/late/diagnostics.rs Outdated

surechen force-pushed the fix_122714 branch from e704d5f to cfe5a1eCompare April 9, 2024 12:00

surechen requested a review from oli-obk April 9, 2024 12:02

fmease requested changes Apr 9, 2024
View reviewed changes

surechen force-pushed the fix_122714 branch from cfe5a1e to 52b1ed0Compare April 9, 2024 12:40

rustbot assigned fmease and unassigned oli-obk Apr 9, 2024

surechen requested a review from fmease April 10, 2024 01:22

fmease requested changes Apr 23, 2024
View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2024

surechen force-pushed the fix_122714 branch from 52b1ed0 to 8aad60dCompare April 28, 2024 10:30

surechen force-pushed the fix_122714 branch from 341b9c6 to 8e42b2eCompare April 28, 2024 12:04

This comment has been minimized.
Sign in to view

surechen force-pushed the fix_122714 branch from 8e42b2e to 82f9833Compare April 28, 2024 12:28

surechen requested a review from fmease April 29, 2024 01:09

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 29, 2024

fmease approved these changes May 18, 2024
View reviewed changes

fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2024

Fix incorrect suggestion for undeclared hrtb lifetimes in where clauses.
4ebbb5f
fixesrust-lang#122714

surechen force-pushed the fix_122714 branch from 82f9833 to 4ebbb5fCompare May 20, 2024 12:32

surechen requested a review from fmease May 21, 2024 01:22

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 21, 2024

fmease approved these changes May 21, 2024
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2024

matthiaskrgr mentioned this pull request May 21, 2024
Rollup of 6 pull requests #125371
Closed

fmease mentioned this pull request May 21, 2024
Rollup of 6 pull requests #125372
Closed

matthiaskrgr mentioned this pull request May 21, 2024
Rollup of 6 pull requests #125379
Merged

bors merged commit 6009cb7 into rust-lang:masterMay 21, 2024

rustbot added this to the 1.80.0 milestone May 21, 2024

Uh oh!

Uh oh!

Conversation

surechen commented Mar 27, 2024

Uh oh!

rustbot commented Mar 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oli-obk commented Apr 9, 2024

Uh oh!

fmease left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

surechen commented Apr 24, 2024

Uh oh!

This comment has been minimized.

fmease left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

surechen commented May 21, 2024

Uh oh!

fmease left a comment

Choose a reason for hiding this comment

Uh oh!

fmease commented May 21, 2024

Uh oh!

bors commented May 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants