Skip to content

Add fn const BuildHasherDefault::new - #123198

Merged
bors merged 1 commit into
rust-lang:masterfrom
krtab:build_hasher_default_const_new
Apr 2, 2024
Merged

Add fn const BuildHasherDefault::new#123198
bors merged 1 commit into
rust-lang:masterfrom
krtab:build_hasher_default_const_new

Conversation

@krtab

Copy link
Copy Markdown
Contributor

See tracking issue for justification.

Because `HashMap::with_hasher` constness is being stabilized this will
in turn allow creating empty HashMap<K,V,BuildHasherDefault<H>> in const
context for any H: Default + Hasher.
@rustbot

Copy link
Copy Markdown
Collaborator

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 29, 2024
@cuviper

Copy link
Copy Markdown
Member

@rustbot label -T-libs +T-libs-api
r? libs-api

@rustbotrustbot added T-libs-api [DEPRECATED; DO NOT USE] and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 29, 2024
@rustbotrustbot assigned Amanieu and unassigned cuviperMar 29, 2024
@AmanieuAmanieu added I-libs-api-nominated [DEPRECATED; DO NOT USE] and removed I-libs-api-nominated [DEPRECATED; DO NOT USE] labels Mar 30, 2024
@Amanieu

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Apr 2, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 54ab425 has been approved by Amanieu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 2, 2024
…ew, r=Amanieu
Add fn const BuildHasherDefault::new
See [tracking issue](rust-lang#123197) for justification.
This was referenced Apr 2, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2024
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#123198 (Add fn const BuildHasherDefault::new)
- rust-lang#123226 (De-LLVM the unchecked shifts [MCP#693])
- rust-lang#123302 (Make sure to insert `Sized` bound first into clauses list)
- rust-lang#123348 (rustdoc: add a couple of regression tests)
- rust-lang#123362 (Check that nested statics in thread locals are duplicated per thread.)
- rust-lang#123368 (CFI: Support non-general coroutines)
- rust-lang#123375 (rustdoc: synthetic auto trait impls: accept unresolved region vars for now)
- rust-lang#123378 (Update sysinfo to 0.30.8)
Failed merges:
- rust-lang#123349 (Fix capture analysis for by-move closure bodies)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit d63ddef into rust-lang:masterApr 2, 2024
@rustbotrustbot added this to the 1.79.0 milestone Apr 2, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2024
Rollup merge of rust-lang#123198 - krtab:build_hasher_default_const_new, r=Amanieu
Add fn const BuildHasherDefault::new
See [tracking issue](rust-lang#123197) for justification.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@krtab@rustbot@cuviper@Amanieu@bors