Skip to content

Rewrite TLS on platforms without threads - #123724

Merged
bors merged 1 commit into
rust-lang:masterfrom
joboet:static_tls
May 24, 2024
Merged

Rewrite TLS on platforms without threads#123724
bors merged 1 commit into
rust-lang:masterfrom
joboet:static_tls

Conversation

@joboet

Copy link
Copy Markdown
Member

The saga of #110897 continues!

r? @m-ou-se if you have time

@joboetjoboet added the A-thread-locals Area: Thread local storage (TLS) label Apr 10, 2024
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 10, 2024
@bors

bors commented Apr 21, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #124208) made this pull request unmergeable. Please resolve the merge conflicts.

@m-ou-se

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented May 23, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 8e4a6af has been approved by m-ou-se

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2024
@bors

bors commented May 24, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8e4a6af with merge 78dd504...

@bors

bors commented May 24, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 78dd504 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label May 24, 2024
@bors
bors merged commit 78dd504 into rust-lang:masterMay 24, 2024
@rustbotrustbot added this to the 1.80.0 milestone May 24, 2024
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (78dd504): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.784s -> 672.268s (0.07%)
Artifact size: 315.72 MiB -> 315.71 MiB (-0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-thread-localsArea: Thread local storage (TLS)merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@joboet@bors@m-ou-se@rust-timer@rustbot