Uh oh!
There was an error while loading. Please reload this page.
Properly handle emojis as literal prefix in macros - #123752
Merged
Merged
Conversation
rustbot
commented
Apr 10, 2024
Collaborator
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
estebank
commented
Apr 10, 2024
ContributorAuthor
This can safely ride the train, but proposing for beta backport to expedite the fix landing on stable. This is an old stable-to-stable regression. Reminds me of the time we accepted any random identifier as a literal prefix with no error whatsoever 😬 |
estebank
commented
Apr 10, 2024
ContributorAuthor
Just in case @bors try @craterbot check |
craterbot
commented
Apr 10, 2024
Collaborator
🚨 Error: missing start toolchain 🆘 If you have any trouble with Crater please ping |
estebank
commented
Apr 10, 2024
ContributorAuthor
@bors try |
bors
commented
Apr 10, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2024
Properly handle emojis as literal prefix in macros
Do not accept the following
```rust
macro_rules! lexes {($($_:tt)*) => {}}
lexes!(🐛"foo");
```
Before, invalid emoji identifiers were gated during parsing instead of lexing in all cases, but this didn't account for macro expansion of literal prefixes.
Fixrust-lang#123696.
This comment has been minimized.
This comment has been minimized.
rustbot
commented
Apr 10, 2024
Collaborator
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
This comment has been minimized.
This comment has been minimized.
Do not accept the following
```rust
macro_rules! lexes {($($_:tt)*) => {}}
lexes!(🐛"foo");
```
Before, invalid emoji identifiers were gated during parsing instead of lexing in all cases, but this didn't account for macro expansion of literal prefixes.
Fixrust-lang#123696.estebank
commented
Apr 10, 2024
ContributorAuthor
@bors try |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2024
Properly handle emojis as literal prefix in macros
Do not accept the following
```rust
macro_rules! lexes {($($_:tt)*) => {}}
lexes!(🐛"foo");
```
Before, invalid emoji identifiers were gated during parsing instead of lexing in all cases, but this didn't account for macro pre-expansion of literal prefixes.
Fixrust-lang#123696.bors
commented
Apr 10, 2024
Collaborator
bors
commented
Apr 11, 2024
Collaborator
☀️ Try build successful - checks-actions |
estebank
commented
Apr 11, 2024
ContributorAuthor
@craterbot check |
craterbot
commented
Apr 11, 2024
Collaborator
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
commented
Apr 11, 2024
Collaborator
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
wesleywiser
approved these changes
Apr 11, 2024
wesleywiser
left a comment
Member
There was a problem hiding this comment.
Code looks good to me, let's see what crater says...
apiraino
commented
Apr 11, 2024
Contributor
Beta backport declined as per compiler team on Zulip. As pointed out in this comment, it can ride the trains and reach stable on its legs 🚶 @rustbot label -beta-nominated |
craterbot
commented
Apr 12, 2024
Collaborator
🎉 Experiment
|
estebank
commented
Apr 12, 2024
ContributorAuthor
I'm glad to see that no-one has been naughty with this oversight. |
wesleywiser
commented
Apr 18, 2024
Member
@bors r+ |
bors
commented
Apr 18, 2024
Collaborator
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 18, 2024
Properly handle emojis as literal prefix in macros
Do not accept the following
```rust
macro_rules! lexes {($($_:tt)*) => {}}
lexes!(🐛"foo");
```
Before, invalid emoji identifiers were gated during parsing instead of lexing in all cases, but this didn't account for macro pre-expansion of literal prefixes.
Fixrust-lang#123696.GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 18, 2024
Properly handle emojis as literal prefix in macros
Do not accept the following
```rust
macro_rules! lexes {($($_:tt)*) => {}}
lexes!(🐛"foo");
```
Before, invalid emoji identifiers were gated during parsing instead of lexing in all cases, but this didn't account for macro pre-expansion of literal prefixes.
Fixrust-lang#123696.workingjubilee added a commit
to workingjubilee/rustc
that referenced
this pull request
Apr 18, 2024
Properly handle emojis as literal prefix in macros
Do not accept the following
```rust
macro_rules! lexes {($($_:tt)*) => {}}
lexes!(🐛"foo");
```
Before, invalid emoji identifiers were gated during parsing instead of lexing in all cases, but this didn't account for macro pre-expansion of literal prefixes.
Fixrust-lang#123696.bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 18, 2024
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#117919 (Introduce perma-unstable `wasm-c-abi` flag) - rust-lang#123571 (Correctly change type when adding adjustments on top of `NeverToAny`) - rust-lang#123752 (Properly handle emojis as literal prefix in macros) - rust-lang#123980 ( Add an opt-in to store incoming edges in `VecGraph` + misc) - rust-lang#124110 (Fix negating `f16` and `f128` constants) - rust-lang#124116 (when suggesting RUST_BACKTRACE=1, add a special note for Miri's env var isolation) r? `@ghost` `@rustbot` modify labels: rollup
workingjubilee added a commit
to workingjubilee/rustc
that referenced
this pull request
Apr 18, 2024
Properly handle emojis as literal prefix in macros
Do not accept the following
```rust
macro_rules! lexes {($($_:tt)*) => {}}
lexes!(🐛"foo");
```
Before, invalid emoji identifiers were gated during parsing instead of lexing in all cases, but this didn't account for macro pre-expansion of literal prefixes.
Fixrust-lang#123696.bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2024
…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#117919 (Introduce perma-unstable `wasm-c-abi` flag) - rust-lang#123406 (Force exhaustion in iter::ArrayChunks::into_remainder) - rust-lang#123752 (Properly handle emojis as literal prefix in macros) - rust-lang#123935 (Don't inline integer literals when they overflow - new attempt) - rust-lang#123980 ( Add an opt-in to store incoming edges in `VecGraph` + misc) - rust-lang#124019 (Use raw-dylib for Windows synchronization functions) - rust-lang#124110 (Fix negating `f16` and `f128` constants) - rust-lang#124112 (Fix ICE when there is a non-Unicode entry in the incremental crate directory) - rust-lang#124116 (when suggesting RUST_BACKTRACE=1, add a special note for Miri's env var isolation) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2024
…kingjubilee Rollup of 7 pull requests Successful merges: - rust-lang#123406 (Force exhaustion in iter::ArrayChunks::into_remainder) - rust-lang#123752 (Properly handle emojis as literal prefix in macros) - rust-lang#123935 (Don't inline integer literals when they overflow - new attempt) - rust-lang#123980 ( Add an opt-in to store incoming edges in `VecGraph` + misc) - rust-lang#124019 (Use raw-dylib for Windows synchronization functions) - rust-lang#124110 (Fix negating `f16` and `f128` constants) - rust-lang#124116 (when suggesting RUST_BACKTRACE=1, add a special note for Miri's env var isolation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2024
Rollup merge of rust-lang#123752 - estebank:emoji-prefix, r=wesleywiser Properly handle emojis as literal prefix in macros Do not accept the following ```rust macro_rules! lexes {($($_:tt)*) => {}} lexes!(🐛"foo"); ``` Before, invalid emoji identifiers were gated during parsing instead of lexing in all cases, but this didn't account for macro pre-expansion of literal prefixes. Fixrust-lang#123696.
mattheww added a commit
to mattheww/lexeywan
that referenced
this pull request
Sep 10, 2024
This bug is now fixed in stable rustc. See rust-lang/rust#123696rust-lang/rust#123752
nnethercote added a commit
to nnethercote/rust
that referenced
this pull request
Nov 19, 2024
It was added in rust-lang#123752 to handle some cases involving emoji, but it isn't necessary because it's always treated the same as `TokenKind::InvalidIdent`. This commit removes it, which makes things a little simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not accept the following
Before, invalid emoji identifiers were gated during parsing instead of lexing in all cases, but this didn't account for macro pre-expansion of literal prefixes.
Fix#123696.