Uh oh!
There was an error while loading. Please reload this page.
Collapse -success and -failure jobs into an -outcome job - #124014
Collapse -success and -failure jobs into an -outcome job#124014emilyalbini wants to merge 1 commit into
-success and -failure jobs into an -outcome job#124014Conversation
Before this commit we had auto-success, auto-failure, try-success and try-failure. The only difference between a -success and a -failure job though was the exit code that was returned in the job. To reduce clutter, this PR collapses each pair of jobs into a single job that is executed regardless of whether the dependency jobs passed or failed. Then a simple jq invocation checks whether the dependencies passed or failed to determine the exit code.
rustbot
commented
Apr 16, 2024
Could not assign reviewer from: |
rustbot
commented
Apr 16, 2024
@pietroalbini: no appropriate reviewer found, use |
rustbot
commented
Apr 16, 2024
Please choose another assignee. (see documentation) |
emilyalbini
commented
Apr 16, 2024
r? @Kobzol |
| @@ -290,20 +290,11 @@ x--expand-yaml-anchors--remove: | |||
| - &base-outcome-job | |||
There was a problem hiding this comment.
The comment above this isn't updated (it still mentions try-success etc.)
| <<: *base-success-job | ||
| auto-failure: | ||
| # !cancelled() executes the job regardless of whether it passed or failed | ||
| if: "!cancelled() && github.event_name == 'push' && (github.ref == 'refs/heads/try' || github.ref == 'refs/heads/try-perf') && github.repository == 'rust-lang-ci/rust'" |
There was a problem hiding this comment.
Just thinking out loud: do we actually need this if (more specifically, the github.XXX parts? Shouldn't this job be skipped automatically if try (which it needs) is skipped?
Kobzol
commented
Apr 22, 2024
@rustbot author |
bors
commented
Apr 24, 2024
☔ The latest upstream changes (presumably #124175) made this pull request unmergeable. Please resolve the merge conflicts. |
emilyalbini
commented
Apr 27, 2024
Superseded by #124366. |
Before this commit we had
auto-success,auto-failure,try-successandtry-failure. The only difference between a-successand a-failurejob though was the exit code that was returned in the job.To reduce clutter, this PR collapses each pair of jobs into a single job that is executed regardless of whether the dependency jobs passed or failed. Then a simple jq invocation checks whether the dependencies passed or failed to determine the exit code.
r? @Kobzol