Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #124111
Merged
Merged
Conversation
This comment was historically inside a block guarded by `if let Some(otherwise_block) = otherwise`. When rust-lang#120978 made the otherwise block non-optional, it also flattened that region of code. Doing so left this comment awkwardly stranded above an unrelated line of code, without its original context. We can restore that context by moving it above the declaration of `otherwise`.
In llvm/llvm-project@9067070 they ended up largely reverting llvm/llvm-project@e817966. This means the change we did in rust-lang/rust@b378059 is now only corrct for LLVM 18...so we have to adjust again. @rustbot label: +llvm-main
…n, r=notriddle Fix copy path button Currently, on all nightly docs, clicking on the "copy path" button triggers a JS error. It's because changes in rust-lang#123706 forgot to update the JS (it contained an image before but not anymore). I had to make some small changes in the CSS to fix the display when the button was clicked as well. r? ``@notriddle``
…leanups, r=Nadrieril Match ergonomics 2024: miscellaneous code cleanups - Store `ByRef` instead of `BindingAnnotation` in `PatInfo` - Rename `BindingAnnotation` to `BindingMode` r? ``@Nadrieril`` cc rust-lang#123076 ``@rustbot`` label A-patterns
Move confusing comment about otherwise blocks in `lower_match_tree` This comment was historically inside a block guarded by `if let Some(otherwise_block) = otherwise`. When rust-lang#120978 made the “otherwise block” non-optional, it also flattened that region of code. Doing so left this comment awkwardly stranded above an unrelated line of code, without its original context. We can restore that context by moving it above the declaration of `otherwise`. r? ``@Nadrieril``
…uviper llvm: update riscv target feature to match LLVM 19 In llvm/llvm-project@9067070 they ended up largely reverting llvm/llvm-project@e817966. This means the change we did in rust-lang/rust@b378059 is now only corrct for LLVM 18...so we have to adjust again. ``@rustbot`` label: +llvm-main
fix: make `str::from_raw_parts_mut` `mut` `str::from_raw_parts_mut` wasn't actually `mut` rust-lang#119206
matthiaskrgr
commented
Apr 18, 2024
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Apr 18, 2024
Collaborator
bors
commented
Apr 18, 2024
Collaborator
bors
commented
Apr 18, 2024
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Apr 18, 2024
Collaborator
📌 Perf builds for each rolled up PR:
previous master: b1248bc60d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 18, 2024
rust-timer
commented
Apr 18, 2024
Collaborator
Finished benchmarking commit (ecd4547): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 677.64s -> 678.014s (0.06%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
lower_match_tree#124064 (Move confusing comment about otherwise blocks inlower_match_tree)str::from_raw_parts_mutmut#124100 (fix: makestr::from_raw_parts_mutmut)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup