interpret: use ScalarInt for bin-ops; avoid PartialOrd for ScalarInt by RalfJung · Pull Request #124113 · rust-lang/rust

RalfJung · 2024-04-18T07:01:54Z

Best reviewed commit-by-commit

r? @oli-obk

rustbot · 2024-04-18T07:02:03Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

…ed the sign

RalfJung · 2024-04-18T12:29:01Z

Let's make sure this doesn't have unexpected perf impact...
@bors try @rust-timer queue

bors · 2024-04-18T12:30:12Z

⌛ Trying commit a1049bd with merge 85843df...

interpret: use ScalarInt for bin-ops; avoid PartialOrd for ScalarInt Best reviewed commit-by-commit r? `@oli-obk`

bors · 2024-04-18T14:03:09Z

☀️ Try build successful - checks-actions
Build commit: 85843df (85843df5696439ac0ce491b7bd20b0f7c1aecca1)

bors · 2024-04-18T14:03:09Z

☀️ Try build successful - checks-actions
Build commit: 85843df (85843df5696439ac0ce491b7bd20b0f7c1aecca1)

rust-timer · 2024-04-18T15:19:42Z

Finished benchmarking commit (85843df): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.8%, 1.3%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[0.8%, 1.3%]	4

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.875s -> 677.371s (0.07%)
Artifact size: 315.38 MiB -> 315.34 MiB (-0.01%)

RalfJung · 2024-04-18T17:24:11Z

Damn, I was a bit too optimistic.

RalfJung · 2024-04-18T17:25:14Z

@bors try @rust-timer queue

bors · 2024-04-18T17:26:25Z

⌛ Trying commit 12b540a with merge c3e1cb8...

interpret: use ScalarInt for bin-ops; avoid PartialOrd for ScalarInt Best reviewed commit-by-commit r? `@oli-obk`

bors · 2024-04-18T18:58:56Z

☀️ Try build successful - checks-actions
Build commit: c3e1cb8 (c3e1cb83f3e8f50b203d1d6c91180b63c1a35e8f)

rust-timer · 2024-04-18T22:26:55Z

Finished benchmarking commit (c3e1cb8): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.3%	[4.3%, 4.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.8%	[3.8%, 3.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.8%	[3.8%, 3.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.731s -> 678.531s (0.27%)
Artifact size: 316.11 MiB -> 315.37 MiB (-0.23%)

RalfJung · 2024-04-19T12:21:49Z

@bors try @rust-timer queue

bors · 2024-04-19T12:22:59Z

⌛ Trying commit bc52909 with merge 250e633...

interpret: use ScalarInt for bin-ops; avoid PartialOrd for ScalarInt Best reviewed commit-by-commit r? `@oli-obk`

bors · 2024-04-19T13:54:58Z

☀️ Try build successful - checks-actions
Build commit: 250e633 (250e633361a8a798cfae7df3846484edcfce1904)

rust-timer · 2024-04-19T15:10:52Z

Finished benchmarking commit (250e633): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-0.2%, -0.2%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-0.7%, -0.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.234s -> 671.445s (-0.27%)
Artifact size: 315.21 MiB -> 315.22 MiB (0.00%)

we don't know their sign so we cannot, in general, order them properly

RalfJung · 2024-04-19T15:18:20Z

Nice. :)

This is ready. I wish github would tell me the commit ID at the time of your review, @oli-obk, then I could provide a diff... I think it's this.

oli-obk · 2024-04-19T15:32:56Z

@bors r+

bors · 2024-04-19T15:32:58Z

📌 Commit d3f927d has been approved by oli-obk

It is now in the queue for this repository.

bors · 2024-04-19T17:00:32Z

⌛ Testing commit d3f927d with merge ce3263e...

bors · 2024-04-19T19:17:49Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing ce3263e to master...

rust-timer · 2024-04-19T20:34:39Z

Finished benchmarking commit (ce3263e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.2%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.4%, -0.2%]	4

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.9%, 1.1%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[0.9%, 1.1%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.762s -> 672.283s (-0.07%)
Artifact size: 315.24 MiB -> 315.27 MiB (0.01%)

…-obk interpret: use ScalarInt for bin-ops; avoid PartialOrd for ScalarInt Best reviewed commit-by-commit r? `@oli-obk`

rustbot assigned oli-obk Apr 18, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 18, 2024

This comment has been minimized.
Sign in to view

RalfJung force-pushed the interpret-scalar-ops branch from 542af33 to de6e439Compare April 18, 2024 07:33

bjorn3 reviewed Apr 18, 2024
View reviewed changes

Comment threadcompiler/rustc_const_eval/src/interpret/operand.rs

interpret/binary_int_op: avoid dropping to raw ints until we determin…
5e6184c
…ed the sign

RalfJung force-pushed the interpret-scalar-ops branch from de6e439 to a1049bdCompare April 18, 2024 12:25

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 18, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2024
Auto merge ofrust-lang#124113- RalfJung:interpret-scalar-ops, r=<try>
85843df
interpret: use ScalarInt for bin-ops; avoid PartialOrd for ScalarInt Best reviewed commit-by-commit r? `@oli-obk`

This comment has been minimized.
Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 18, 2024

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 18, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2024
Auto merge ofrust-lang#124113- RalfJung:interpret-scalar-ops, r=<try>
c3e1cb8
interpret: use ScalarInt for bin-ops; avoid PartialOrd for ScalarInt Best reviewed commit-by-commit r? `@oli-obk`

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 18, 2024

This comment was marked as resolved.
Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2024

This comment was marked as resolved.
Sign in to view

RalfJung force-pushed the interpret-scalar-ops branch from 0080e04 to bc52909Compare April 19, 2024 12:21

This comment has been minimized.
Sign in to view

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2024
Auto merge ofrust-lang#124113- RalfJung:interpret-scalar-ops, r=<try>
250e633
interpret: use ScalarInt for bin-ops; avoid PartialOrd for ScalarInt Best reviewed commit-by-commit r? `@oli-obk`

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 19, 2024

avoid PartialOrd on ScalarInt
d3f927d
we don't know their sign so we cannot, in general, order them properly

RalfJung force-pushed the interpret-scalar-ops branch from bc52909 to d3f927dCompare April 19, 2024 15:17

oli-obk approved these changes Apr 19, 2024
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 19, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 19, 2024

bors merged commit ce3263e into rust-lang:masterApr 19, 2024

rustbot added this to the 1.79.0 milestone Apr 19, 2024

RalfJung deleted the interpret-scalar-ops branch April 20, 2024 06:29

bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Apr 23, 2024
Auto merge ofrust-lang#124113- RalfJung:interpret-scalar-ops, r=oli…
a2a949b
…-obk interpret: use ScalarInt for bin-ops; avoid PartialOrd for ScalarInt Best reviewed commit-by-commit r? `@oli-obk`

Uh oh!

Uh oh!

Conversation

RalfJung commented Apr 18, 2024

Uh oh!

rustbot commented Apr 18, 2024

Uh oh!

This comment has been minimized.

Uh oh!

RalfJung commented Apr 18, 2024

Uh oh!

This comment has been minimized.

bors commented Apr 18, 2024

Uh oh!

bors commented Apr 18, 2024

Uh oh!

bors commented Apr 18, 2024

Uh oh!

This comment has been minimized.

rust-timer commented Apr 18, 2024

Overall result: ❌ regressions - ACTION NEEDED

Uh oh!

RalfJung commented Apr 18, 2024

Uh oh!

RalfJung commented Apr 18, 2024

Uh oh!

This comment has been minimized.

bors commented Apr 18, 2024

Uh oh!

bors commented Apr 18, 2024

Uh oh!

This comment has been minimized.

rust-timer commented Apr 18, 2024

Overall result: ❌ regressions - no action needed

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

RalfJung commented Apr 19, 2024

Uh oh!

This comment has been minimized.

bors commented Apr 19, 2024

Uh oh!

bors commented Apr 19, 2024

Uh oh!

This comment has been minimized.

rust-timer commented Apr 19, 2024

Overall result: ✅ improvements - no action needed

Uh oh!

RalfJung commented Apr 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Apr 19, 2024

Uh oh!

bors commented Apr 19, 2024

Uh oh!

bors commented Apr 19, 2024

Uh oh!

bors commented Apr 19, 2024

Uh oh!

rust-timer commented Apr 19, 2024

Overall result: ✅ improvements - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

RalfJung commented Apr 19, 2024•
edited
Loading