Uh oh!
There was an error while loading. Please reload this page.
Make sure that the method resolution matches in note_source_of_type_mismatch_constraint - #124227
Merged
Merged
Conversation
rustbot
commented
Apr 21, 2024
Collaborator
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
This comment has been minimized.
This comment has been minimized.
compiler-errorsforce-pushed
the
hack-check-method-res
branch
from
April 21, 2024 15:11
70bf324 to
483f13cCompareNadrieril
commented
Apr 21, 2024
Member
r? compiler |
compiler-errors
commented
Apr 22, 2024
ContributorAuthor
r? compiler |
compiler-errors
commented
May 14, 2024
ContributorAuthor
@estebank friendly ping since it has been >2 weeks |
compiler-errors
commented
May 20, 2024
ContributorAuthor
r? compiler |
compiler-errors
commented
May 20, 2024
ContributorAuthor
r? compiler |
estebank
commented
May 21, 2024
Contributor
@bors r+ |
bors
commented
May 21, 2024
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 22, 2024
…res, r=estebank Make sure that the method resolution matches in `note_source_of_type_mismatch_constraint` `note_source_of_type_mismatch_constraint` is a pile of hacks that I implemented to cover up another pile of hacks. It does a bunch of re-confirming methods, but it wasn't previously checking that the methods it was looking (back) up were equal to the methods we previously had. This PR adds those checks. Fixesrust-lang#118185
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#124227 (Make sure that the method resolution matches in `note_source_of_type_mismatch_constraint`) - rust-lang#124896 (miri: rename intrinsic_fallback_checks_ub to intrinsic_fallback_is_spec) - rust-lang#125015 (Pattern types: Prohibit generic args on const params) - rust-lang#125043 (reference type safety invariant docs: clarification) - rust-lang#125259 (An async closure may implement `FnMut`/`Fn` if it has no self-borrows) - rust-lang#125306 (Force the inner coroutine of an async closure to `move` if the outer closure is `move` and `FnOnce`) - rust-lang#125378 (remove tracing tree indent lines) r? `@ghost` `@rustbot` modify labels: rollup
bors
commented
May 22, 2024
Collaborator
bors
commented
May 22, 2024
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
May 22, 2024
Collaborator
Finished benchmarking commit (f0038a7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 3.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 671.163s -> 672.314s (0.17%) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note_source_of_type_mismatch_constraintis a pile of hacks that I implemented to cover up another pile of hacks.It does a bunch of re-confirming methods, but it wasn't previously checking that the methods it was looking (back) up were equal to the methods we previously had. This PR adds those checks.
Fixes#118185