Skip to content

Add --print=check-cfg to get the expected configs - #124320

Merged
bors merged 1 commit into
rust-lang:masterfrom
Urgau:print-check-cfg
May 29, 2024
Merged

Add --print=check-cfg to get the expected configs#124320
bors merged 1 commit into
rust-lang:masterfrom
Urgau:print-check-cfg

Conversation

@Urgau

@UrgauUrgau commented Apr 24, 2024

Copy link
Copy Markdown
Member

This PR adds a new --print variant check-cfg to get the expected configs.

Details and rational can be found on the MCP: rust-lang/compiler-team#743

@rustbot label +F-check-cfg +S-waiting-on-MCP
r? @petrochenkov

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 24, 2024
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in run-make tests.

cc @jieyouxu

@rustbotrustbot added the F-check-cfg --check-cfg label Apr 24, 2024
@rust-log-analyzer

This comment has been minimized.

@rustbotrustbot added the S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. label Apr 24, 2024
@bors

This comment was marked as resolved.

@petrochenkovpetrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2024
@Urgau

Copy link
Copy Markdown
MemberAuthor

MCP was accepted. 🎉

@rustbot labels -S-waiting-on-MCP +S-waiting-on-review

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. labels May 25, 2024
@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 28, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit ac59bdc has been approved by petrochenkov

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request May 28, 2024
Add `--print=check-cfg` to get the expected configs
This PR adds a new `--print` variant `check-cfg` to get the expected configs.
Details and rational can be found on the MCP: rust-lang/compiler-team#743
`@rustbot` label +F-check-cfg +S-waiting-on-MCP
r? `@petrochenkov`
@jieyouxujieyouxu mentioned this pull request May 28, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 29, 2024
Rollup of 8 pull requests
Successful merges:
- rust-lang#124251 (Add an intrinsic for `ptr::metadata`)
- rust-lang#124320 (Add `--print=check-cfg` to get the expected configs)
- rust-lang#125226 (Make more of the test suite run on Mac Catalyst)
- rust-lang#125381 (Silence some resolve errors when there have been glob import errors)
- rust-lang#125633 (miri: avoid making a full copy of all new allocations)
- rust-lang#125638 (Rewrite `lto-smoke`, `simple-rlib` and `mixing-deps` `run-make` tests in `rmake.rs` format)
- rust-lang#125639 (Support `./x doc run-make-support --open`)
- rust-lang#125664 (Tweak relations to no longer rely on `TypeTrace`)
r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxujieyouxu mentioned this pull request May 29, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 29, 2024
Rollup of 8 pull requests
Successful merges:
- rust-lang#124251 (Add an intrinsic for `ptr::metadata`)
- rust-lang#124320 (Add `--print=check-cfg` to get the expected configs)
- rust-lang#125226 (Make more of the test suite run on Mac Catalyst)
- rust-lang#125381 (Silence some resolve errors when there have been glob import errors)
- rust-lang#125633 (miri: avoid making a full copy of all new allocations)
- rust-lang#125638 (Rewrite `lto-smoke`, `simple-rlib` and `mixing-deps` `run-make` tests in `rmake.rs` format)
- rust-lang#125639 (Support `./x doc run-make-support --open`)
- rust-lang#125664 (Tweak relations to no longer rely on `TypeTrace`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7e441a1 into rust-lang:masterMay 29, 2024
@rustbotrustbot added this to the 1.80.0 milestone May 29, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 29, 2024
Rollup merge of rust-lang#124320 - Urgau:print-check-cfg, r=petrochenkov
Add `--print=check-cfg` to get the expected configs
This PR adds a new `--print` variant `check-cfg` to get the expected configs.
Details and rational can be found on the MCP: rust-lang/compiler-team#743
``@rustbot`` label +F-check-cfg +S-waiting-on-MCP
r? ``@petrochenkov``
@UrgauUrgau mentioned this pull request May 29, 2024
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-check-cfg--check-cfgS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Urgau@rustbot@rust-log-analyzer@bors@petrochenkov