Skip to content

CI: remove master job - #124332

Merged
bors merged 6 commits into
rust-lang:masterfrom
Kobzol:toolstate-auto-build
Apr 29, 2024
Merged

CI: remove master job#124332
bors merged 6 commits into
rust-lang:masterfrom
Kobzol:toolstate-auto-build

Conversation

@Kobzol

@KobzolKobzol commented Apr 24, 2024•
edited
Loading

Copy link
Copy Markdown
Member

It only had one job (pun intended), to publish the toolstate. We could probably do that at the end of auto builds instead, which is what is done in this PR.

r? @pietroalbini

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 24, 2024
RalfJung
RalfJung reviewed Apr 24, 2024
View reviewed changes
Comment threadsrc/ci/github-actions/ci.yml Outdated
@Kobzol
Kobzolforce-pushed the toolstate-auto-build branch from 2dfe26c to 65507eaCompareApril 24, 2024 13:23
@Kobzol

Kobzol commented Apr 24, 2024

Copy link
Copy Markdown
MemberAuthor

Ok, second attempt. I have moved toolstate publishing to the auto-success job, since it is already configured to run when the auto job succeeds. This conflicts with the change to unify the success/failure jobs though.

@emilyalbini

emilyalbini commented Apr 24, 2024

Copy link
Copy Markdown
Member

Not sure exactly why git decided to render the diff that way in the second commit 😅

r=me once the other PR is merged

@Kobzol

Kobzol commented Apr 24, 2024

Copy link
Copy Markdown
MemberAuthor

Yeah that was super weird :D I moved the steps down from the anchor, but GH (also local git diff) decided to instead move the jobs up.

@Kobzol
Kobzolforce-pushed the toolstate-auto-build branch from 65507ea to 86da0e7CompareApril 25, 2024 08:48
@Kobzol

Kobzol commented Apr 25, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Rebased since #124327 has been merged. I also added two new commits, so not approving immediately.

@KobzolKobzol mentioned this pull request Apr 25, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 25, 2024
@bors
Auto merge ofrust-lang#124366- Kobzol:remove-yaml-expansion, r=<try>
6629a69
CI: remove `expand-yaml-anchors`
Opening for experiments.
Blocked on rust-lang#124332 (first 4 commits are from that PR).
r? `@ghost`
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 25, 2024
@bors
Auto merge ofrust-lang#124366- Kobzol:remove-yaml-expansion, r=<try>
9026eae
CI: remove `expand-yaml-anchors`
Opening for experiments.
Blocked on rust-lang#124332 (first 4 commits are from that PR).
r? `@ghost`
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 25, 2024
@bors
Auto merge ofrust-lang#124366- Kobzol:remove-yaml-expansion, r=<try>
f42f9b6
CI: remove `expand-yaml-anchors`
This PR unifies all CI outcome jobs in a single job, and then removes the `expand-yaml-anchors` tool, since it is no longer needed after this change.
Opening for experiments.
Blocked on rust-lang#124332 (first 4 commits are from that PR).
r? `@ghost`
@Kobzol

Kobzol commented Apr 25, 2024

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

emilyalbini
emilyalbini requested changes Apr 27, 2024
View reviewed changes
Comment thread.github/workflows/ci.yml
@emilyalbini

emilyalbini commented Apr 27, 2024

Copy link
Copy Markdown
Member

@bors r+ rollup=iffy

@bors

bors commented Apr 27, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 163ea33 has been approved by pietroalbini

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2024
@bors
Auto merge ofrust-lang#124332- Kobzol:toolstate-auto-build, r=pietr…
2c94366
…oalbini
CI: remove `master` job
It only had one job (pun intended), to publish the toolstate. We could probably do that at the end of `auto` builds instead, which is what is done in this PR.
r? `@pietroalbini`
@bors

bors commented Apr 27, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 163ea33 with merge 2c94366...

@bors

bors commented Apr 27, 2024

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 27, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol

Kobzol commented Apr 27, 2024

Copy link
Copy Markdown
MemberAuthor

Added missing checkout step.

@Kobzol
Kobzol requested a review from emilyalbiniApril 28, 2024 12:25
@emilyalbini

emilyalbini commented Apr 29, 2024

Copy link
Copy Markdown
Member

@bors r+ rollup=iffy

@bors

bors commented Apr 29, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit a700897 has been approved by pietroalbini

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2024
@bors

bors commented Apr 29, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a700897 with merge e27af29...

@bors

bors commented Apr 29, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing e27af29 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 29, 2024
@bors
bors merged commit e27af29 into rust-lang:masterApr 29, 2024
@rustbotrustbot added this to the 1.80.0 milestone Apr 29, 2024
@Kobzol
Kobzol deleted the toolstate-auto-build branch April 29, 2024 19:24
@rust-timer

rust-timer commented Apr 29, 2024

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e27af29): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-2.1%[-2.3%, -2.0%]2
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-2.1%[-2.3%, -2.0%]2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		2.1%[2.1%, 2.1%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)2.1%[2.1%, 2.1%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.855s -> 673.188s (0.20%)
Artifact size: 315.98 MiB -> 315.98 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung left review comments
@emilyalbiniemilyalbiniAwaiting requested review from emilyalbini

Assignees

@emilyalbiniemilyalbini

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.80.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Kobzol@emilyalbini@bors@rust-log-analyzer@rust-timer@RalfJung@rustbot