Some hir cleanups

[oli-obk]

It seemed odd to not put AnonConst in the arena, compared with the other types that we did put into an arena. This way we can also give it a Span without growing a lot of other HIR data structures because of the extra field.

r? compiler

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit e4f8b93 with merge a7fe502...

[bors]

☀️ Try build successful - checks-actions
Build commit: a7fe502 (a7fe502a60bdbd0f0ab15109ada21158bd03be5a)

[rust-timer]

Finished benchmarking commit (a7fe502): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.891s -> 671.47s (0.09%)
Artifact size: 315.98 MiB -> 316.02 MiB (0.01%)

[rustbot]

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

[cjgillot]

Should we do the same with ConstBlock?

[oli-obk]

I considered that, but there's two reasons not to do it:

• I did this change because I noticed it in a PR that is removing ConstBlock
• ConstBlock only exists in an ExprKind variant, which has the Span in the Expr and is small enough to not affect ExprKind size

[cjgillot]

@bors r+

[bors]

📌 Commit fea1fe7 has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit fea1fe7 with merge 09cd00f...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 09cd00f to master...

[rust-timer]

Finished benchmarking commit (09cd00f): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.1%]	3
Improvements ✅ (secondary)	-1.1%	[-2.0%, -0.2%]	2
All ❌✅ (primary)	-0.1%	[-0.2%, -0.1%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.8%, 1.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-2.2%, -0.7%]	3
Improvements ✅ (secondary)	-2.8%	[-3.1%, -2.6%]	3
All ❌✅ (primary)	-0.7%	[-2.2%, 1.8%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-0.7%, -0.7%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.126s -> 678.263s (0.61%)
Artifact size: 315.84 MiB -> 315.83 MiB (-0.00%)