Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #124527
Merged
Merged
Conversation
The functionality of all three crates is now available in the standard library.
This was due to the must_use() call. Adding HIR's OffsetOf to the must_use checking within the compiler avoids this issue.
as they have a potential to ICE during layout calculation
Instead of separately hard-coding the operation being visited, we can get it from the match arm pattern by using an as-pattern.
Signed-off-by: Sasha Pourcelot <sasha.pourcelot@protonmail.com>
Pretty-print parenthesis around binary in postfix match Fixesrust-lang#124206.
Use probes more aggressively in new solver ....so that we have the right candidate information when assembling trait and normalizes-to goals. Also gets rid of misc probes. r? lcnr
…i-obk
Remove direct dependencies on lazy_static, once_cell and byteorder
The relevant functionality of all three crates is now available and stable in the standard library, i.e. `std::sync::OnceLock` and `{integer}::to_le_bytes`. I think waiting for `LazyLock` (rust-lang#109736) would give marginally more concise code, but not by much.Fixrust-lang#124478 - offset_of! returns a temporary This was due to the must_use() call. Adding HIR's `OffsetOf` to the must_use checking within the compiler avoids this issue while maintaining the lint output. Fixesrust-lang#124478. `@tgross35`
Mark unions non-const-propagatable in `KnownPanicsLint` without calling layout Fixesrust-lang#123710 The ICE occurs during the layout calculation of the union `InvalidTag` in rust-lang#123710 because the following assert fails:https://github.com/rust-lang/rust/blob/5fe8b697e729b6eb64841a3905e57da1b47f4ca3/compiler/rustc_abi/src/layout.rs#L289-L292 The layout calculation is invoked by `KnownPanicsLint` when it is trying to figure out which locals it can const prop. Since `KnownPanicsLint` is never actually going to const props unions thanks to PR rust-lang#121628 there's no point calling layout to check if it can. So in this fix I skip the call to layout and just mark the local non-const propagatable if it is a union.
coverage: Avoid hard-coded values when visiting logical ops This is a tiny little thing that I noticed during the final review of rust-lang#123409, and I didn't want to hold up the whole PR just for this. Instead of separately hard-coding the operation being visited, we can get it from the match arm pattern by using an as-pattern. `@rustbot` label +A-code-coverage
…ouxu [Refactor] Rename `Lint` and `LintGroup`'s `is_loaded` to `is_externally_loaded` The field being named `is_loaded` was very confusing. Turns out it's true for lints that are registered by external tools like Clippy (I had to look at rust-lang#116412 to know what the variable meant). So I renamed `is_loaded` to `is_externally_loaded` and added some docs.
jieyouxu
commented
Apr 29, 2024
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Apr 29, 2024
Collaborator
bors
commented
Apr 29, 2024
Collaborator
bors
commented
Apr 29, 2024
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Apr 29, 2024
Collaborator
📌 Perf builds for each rolled up PR:
previous master: e27af2917b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 29, 2024
rust-timer
commented
Apr 29, 2024
Collaborator
Finished benchmarking commit (a8a1d3a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 673.188s -> 673.511s (0.05%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
offset_ofreturns a temporary #124478 - offset_of! returns a temporary)KnownPanicsLintwithout calling layout #124504 (Mark unions non-const-propagatable inKnownPanicsLintwithout calling layout)LintandLintGroup'sis_loadedtois_externally_loaded#124522 ([Refactor] RenameLintandLintGroup'sis_loadedtois_externally_loaded)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup