Uh oh!
There was an error while loading. Please reload this page.
Rewrite select (in the new solver) to use a ProofTreeVisitor - #124529
Merged
Conversation
rustbot
commented
Apr 29, 2024
Collaborator
rustbot
commented
Apr 29, 2024
Collaborator
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler-errors
commented
Apr 29, 2024
ContributorAuthor
r? lcnr |
compiler-errorsforce-pushed
the
select
branch
2 times, most recently
from
April 29, 2024 21:06
b7b5763 to
be1d5f4Comparelcnr
reviewed
Apr 29, 2024
Uh oh!
There was an error while loading. Please reload this page.
lcnr
reviewed
Apr 29, 2024
Uh oh!
There was an error while loading. Please reload this page.
bors
commented
Apr 30, 2024
Collaborator
☔ The latest upstream changes (presumably #124558) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errorsforce-pushed
the
select
branch
2 times, most recently
from
May 1, 2024 17:18
32aec4d to
6760051Comparecompiler-errors
commented
May 1, 2024
ContributorAuthor
@bors r=lcnr rollup (new solver only) |
bors
commented
May 1, 2024
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 1, 2024
Rewrite select (in the new solver) to use a `ProofTreeVisitor` We can use a proof tree visitor rather than collecting and recomputing all the nested goals ourselves. Based on rust-lang#124415
This comment has been minimized.
This comment has been minimized.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 1, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#124529 (Rewrite select (in the new solver) to use a `ProofTreeVisitor`) - rust-lang#124542 (Add diagnostic item for `std::iter::Iterator::enumerate`) - rust-lang#124566 (fix `NormalizesTo` proof tree issue) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
commented
May 1, 2024
Member
@bors r- ^ |
compiler-errors
commented
May 1, 2024
ContributorAuthor
@bors r=lcnr |
bors
commented
May 1, 2024
Collaborator
bors
commented
May 2, 2024
Collaborator
bors
commented
May 2, 2024
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
May 2, 2024
Collaborator
Finished benchmarking commit (f92d49b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.001s -> 674.637s (0.09%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can use a proof tree visitor rather than collecting and recomputing all the nested goals ourselves.
Based on #124415