Skip to content

check if x test tests missing any test directory - #124969

Merged
bors merged 3 commits into
rust-lang:masterfrom
onur-ozkan:test-tests-remap
May 11, 2024
Merged

check if x test tests missing any test directory#124969
bors merged 3 commits into
rust-lang:masterfrom
onur-ozkan:test-tests-remap

Conversation

@onur-ozkan

@onur-ozkanonur-ozkan commented May 10, 2024

Copy link
Copy Markdown
Contributor

Add a unit test to ensure we don't skip any test directories for x test tests in the future.

@rustbot

rustbot commented May 10, 2024

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 10, 2024
@onur-ozkanonur-ozkan mentioned this pull request May 10, 2024
Merged
klensy
klensy reviewed May 10, 2024
View reviewed changes
Comment threadsrc/bootstrap/src/core/builder.rs
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan
check if x test tests missing any test directory
c9fb74e
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
remap missing path tests/crashes to tests
569e547
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
add "tidy-alphabetical" check on "tests" remap list
0a0b40a
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@Mark-Simulacrum

Mark-Simulacrum commented May 11, 2024

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented May 11, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 0a0b40a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2024
@bors

bors commented May 11, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 0a0b40a with merge 5bfea35...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
@bors
Auto merge ofrust-lang#124969- onur-ozkan:test-tests-remap, r=Mark-…
5bfea35
…Simulacrum
check if `x test tests` missing any test directory
Add a unit test to ensure we don't skip any test directories for `x test tests` in the future.
@rust-log-analyzer

rust-log-analyzer commented May 11, 2024

Copy link
Copy Markdown
Collaborator

The job armhf-gnu failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors

bors commented May 11, 2024

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 11, 2024
@onur-ozkan

onur-ozkan commented May 11, 2024

Copy link
Copy Markdown
ContributorAuthor

--- stderr -------------------------------
thread 'main' panicked at src/tools/remote-test-client/src/main.rs:310:9:
client.read_exact(&mut header) failed with Connection reset by peer (os error 104)
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

Suspicious and not related. @bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2024
@matthiaskrgrmatthiaskrgr mentioned this pull request May 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
@bors
Auto merge ofrust-lang#125010- matthiaskrgr:rollup-270pck3, r=matth…
686bfc4
…iaskrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#124928 (Stabilize `byte_slice_trim_ascii` for `&[u8]`/`&str`)
- rust-lang#124954 (Document proper usage of `fmt::Error` and `fmt()`'s `Result`.)
- rust-lang#124969 (check if `x test tests` missing any test directory)
- rust-lang#124978 (Handle Deref expressions in invalid_reference_casting)
- rust-lang#125005 (Miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7d7a182 into rust-lang:masterMay 11, 2024
@rustbotrustbot added this to the 1.80.0 milestone May 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
@rust-timer
Unrolled build forrust-lang#124969
823a653
Rollup merge of rust-lang#124969 - onur-ozkan:test-tests-remap, r=Mark-Simulacrum
check if `x test tests` missing any test directory
Add a unit test to ensure we don't skip any test directories for `x test tests` in the future.
@onur-ozkan
onur-ozkan deleted the test-tests-remap branch May 11, 2024 15:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@klensyklensyklensy left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.80.0

Development

Successfully merging this pull request may close these issues.

6 participants

@onur-ozkan@rustbot@rust-log-analyzer@Mark-Simulacrum@bors@klensy