Skip to content

Match binding is assignment - #12508

Closed
edwardw wants to merge 1 commit into
rust-lang:masterfrom
edwardw:pat-assign
Closed

Match binding is assignment#12508
edwardw wants to merge 1 commit into
rust-lang:masterfrom
edwardw:pat-assign

Conversation

@edwardw

@edwardwedwardw commented Feb 23, 2014

Copy link
Copy Markdown
Contributor

In its first pass, namely gather_loans, the borrow checker tracks the
initialization sites among other things it does. It does so for let
bindings with initializers but not for bindings in match arms, which are
effectively also assignments. This patch does that for borrow checker.

Closes#12452.

@alexcrichton

alexcrichton commented Feb 24, 2014

Copy link
Copy Markdown
Member

Can you elaborate some more in the commit message about what the bug was and how this fixes it?

cc @nikomatsakis

@edwardw

edwardw commented Feb 24, 2014

Copy link
Copy Markdown
ContributorAuthor

Added more description in commit message. Also tweaked the fix a little bit to follow the convention of existing code more closely.

flaper87
flaper87 reviewed Feb 24, 2014
View reviewed changes
Comment threadsrc/test/compile-fail/borrowck-match-binding-is-assign-enum.rs Outdated

@flaper87flaper87Feb 24, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a small description to these tests about what they are supposed to do and the bug that they're testing?

@edwardwedwardwFeb 24, 2014

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@nikomatsakis

nikomatsakis commented Feb 24, 2014

Copy link
Copy Markdown
Contributor

Also, what @flaper87 said. Something like "// Test that immutable pattern bindings cannot be reassigned."

@edwardw

edwardw commented Feb 24, 2014

Copy link
Copy Markdown
ContributorAuthor

r?

@flaper87

flaper87 commented Feb 24, 2014

Copy link
Copy Markdown
Contributor

@edwardw Could you squash those commits? Also, I think those tests could live in the same file. Not sure what others think but I'd prefer having just 1 borrowck-match-binding-is-assign.rs test that verifies this behavior (and perhaps the number of the issue it fixed in the comments too).

@edwardw

edwardw commented Feb 24, 2014

Copy link
Copy Markdown
ContributorAuthor

@flaper87, can one compile-fail test have multiple failures?

@flaper87

flaper87 commented Feb 24, 2014

Copy link
Copy Markdown
Contributor

@edwardw Yes, for example: https://github.com/mozilla/rust/blob/master/src/test/compile-fail/cleanup-rvalue-scopes-cf.rs

@edwardw
Match binding is assignment
ffb315f
In its first pass, namely gather_loans, the borrow checker tracks the
initialization sites among other things it does. It does so for let
bindings with initializers but not for bindings in match arms, which are
effectively also assignments. This patch does that for borrow checker.
Closesrust-lang#12452.
@edwardw

edwardw commented Feb 24, 2014

Copy link
Copy Markdown
ContributorAuthor

r?

@alexcrichtonalexcrichton mentioned this pull request Feb 25, 2014
Closed
@borsbors closed this in 4243cadFeb 25, 2014
@edwardw
edwardw deleted the pat-assign branch February 25, 2014 07:33
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2022
@bors
Auto merge ofrust-lang#12508- Veykril:req-retry, r=Veykril
604b1c8
fix: Don't respond to cancelled requests when retrying them
Fixesrust-lang/rust-analyzer#12482
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 4, 2024
@bors
Auto merge ofrust-lang#12508- y21:issue12506, r=llogiq
f2020c8
Fix infinite loop in `cast_sign_loss` when peeling unwrap method calls
Fixesrust-lang#12506
The lint wants to peel method calls but didn't actually reassign the expression, leading to an infinite loop.
----
changelog: Fix infinite loop in [`cast_sign_loss`] when having two chained `.unwrap()` calls
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 25, 2024
@bors@flip1995
Auto merge ofrust-lang#12508- y21:issue12506, r=llogiq
4fb631e
Fix infinite loop in `cast_sign_loss` when peeling unwrap method calls
Fixesrust-lang#12506
The lint wants to peel method calls but didn't actually reassign the expression, leading to an infinite loop.
----
changelog: Fix infinite loop in [`cast_sign_loss`] when having two chained `.unwrap()` calls
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 25, 2024
@bors@flip1995
Auto merge ofrust-lang#12508- y21:issue12506, r=llogiq
ec036c7
Fix infinite loop in `cast_sign_loss` when peeling unwrap method calls
Fixesrust-lang#12506
The lint wants to peel method calls but didn't actually reassign the expression, leading to an infinite loop.
----
changelog: Fix infinite loop in [`cast_sign_loss`] when having two chained `.unwrap()` calls
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

match binding is unexpectedly mutable

4 participants

@edwardw@alexcrichton@nikomatsakis@flaper87