Migrate `run-make/issue-30063` to `rmake` by Oneirical · Pull Request #125227 · rust-lang/rust

Oneirical · 2024-05-17T20:53:04Z

Part of #121876 and the associated Google Summer of Code project.

(Sorry about the inconvenience of all these PRs, this is the last one batched for today. I will discuss how we can cut these down a bit.)

The last check was previously commented out in the Makefile, and I have readded it. If it fails the CI, this can be reconsidered.

rustbot · 2024-05-17T20:53:11Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-05-17T20:53:14Z

Some changes occurred in run-make tests.

cc @jieyouxu

jieyouxu · 2024-05-17T23:47:43Z

+// This test tries to reproduce this issue with varied emit flags - if it passes, the codegen-units
+// are being appropriately reset to 1 after each pass.


AFAICT, this isn't actually being checked. We're just checking here that foo.rs "compiles with various cli flags", am I understanding that correctly?

As in, the original test also isn't checking what this comment is saying?

You're right, I wrongfully assumed. The test is checking that the fix did not break compilation, not that the fix itself is doing what it is supposed to do (preventing the annoying re-compilation).

…jieyouxu Migrate `run-make/issue64319` to `rmake` and rename Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). ~~I noticed that the Makefile was not listed in `allowed-run-makefiles` in Tidy. Does this mean the test was being ignored?~~ EDIT: No, it was there, just not in its expected alphabetical order. EDIT2: Perhaps it could be interesting to clean this test visually by looping over the `rustc` calls, like in rust-lang#125227.

Rollup merge of rust-lang#125215 - Oneirical:easy-test-the-second, r=jieyouxu Migrate `run-make/issue64319` to `rmake` and rename Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). ~~I noticed that the Makefile was not listed in `allowed-run-makefiles` in Tidy. Does this mean the test was being ignored?~~ EDIT: No, it was there, just not in its expected alphabetical order. EDIT2: Perhaps it could be interesting to clean this test visually by looping over the `rustc` calls, like in rust-lang#125227.

bors · 2024-05-18T03:12:10Z

☔ The latest upstream changes (presumably #125233) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu · 2024-05-21T22:26:53Z

@rustbot author

Oneirical · 2024-05-22T15:36:19Z

Revisions made.

@rustbot review

jieyouxu · 2024-05-22T20:22:19Z

Thanks, r=me after squashing commits into one.
@bors delegate+

bors · 2024-05-22T20:22:22Z

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

Oneirical · 2024-05-22T21:29:15Z

@bors r=@jieyouxu

bors · 2024-05-22T21:29:17Z

📌 Commit f377ea1 has been approved by jieyouxu

It is now in the queue for this repository.

jieyouxu · 2024-05-23T00:19:09Z

@bors rollup

Migrate `run-make/issue-30063` to `rmake` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). (Sorry about the [inconvenience](rust-lang#125224 (comment)) of all these PRs, this is the last one batched for today. I will discuss how we can cut these down a bit.) The last check was previously commented out in the Makefile, and I have readded it. If it fails the CI, this can be reconsidered.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#125165 (Migrate `run-make/pgo-branch-weights` to `rmake`) - rust-lang#125210 (Cleanup: Fix up some diagnostics) - rust-lang#125224 (Migrate `run-make/issue-53964` to `rmake`) - rust-lang#125227 (Migrate `run-make/issue-30063` to `rmake`) - rust-lang#125383 (Rewrite `emit`, `mixing-formats` and `bare-outfile` `run-make` tests in `rmake.rs` format) - rust-lang#125401 (Migrate `run-make/rustdoc-scrape-examples-macros` to `rmake.rs`) - rust-lang#125409 (Rename `FrameworkOnlyWindows` to `RawDylibOnlyWindows`) - rust-lang#125416 (Use correct param-env in `MissingCopyImplementations`) - rust-lang#125421 (Rewrite `core-no-oom-handling`, `issue-24445` and `issue-38237` `run-make` tests to new `rmake.rs` format) r? `@ghost` `@rustbot` modify labels: rollup

Migrate `run-make/issue-30063` to `rmake` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). (Sorry about the [inconvenience](rust-lang#125224 (comment)) of all these PRs, this is the last one batched for today. I will discuss how we can cut these down a bit.) The last check was previously commented out in the Makefile, and I have readded it. If it fails the CI, this can be reconsidered.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#125210 (Cleanup: Fix up some diagnostics) - rust-lang#125224 (Migrate `run-make/issue-53964` to `rmake`) - rust-lang#125227 (Migrate `run-make/issue-30063` to `rmake`) - rust-lang#125383 (Rewrite `emit`, `mixing-formats` and `bare-outfile` `run-make` tests in `rmake.rs` format) - rust-lang#125401 (Migrate `run-make/rustdoc-scrape-examples-macros` to `rmake.rs`) - rust-lang#125409 (Rename `FrameworkOnlyWindows` to `RawDylibOnlyWindows`) - rust-lang#125416 (Use correct param-env in `MissingCopyImplementations`) - rust-lang#125421 (Rewrite `core-no-oom-handling`, `issue-24445` and `issue-38237` `run-make` tests to new `rmake.rs` format) - rust-lang#125438 (Remove unneeded string conversion) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 7 pull requests Successful merges: - rust-lang#122382 (Detect unused structs which implement private traits) - rust-lang#124389 (Add a warning to proc_macro::Delimiter::None that rustc currently does not respect it.) - rust-lang#125224 (Migrate `run-make/issue-53964` to `rmake`) - rust-lang#125227 (Migrate `run-make/issue-30063` to `rmake`) - rust-lang#125336 (Add dedicated definition for intrinsics) - rust-lang#125401 (Migrate `run-make/rustdoc-scrape-examples-macros` to `rmake.rs`) - rust-lang#125454 (Improve the doc of query associated_item) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#125227 - Oneirical:seventh, r=jieyouxu Migrate `run-make/issue-30063` to `rmake` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). (Sorry about the [inconvenience](rust-lang#125224 (comment)) of all these PRs, this is the last one batched for today. I will discuss how we can cut these down a bit.) The last check was previously commented out in the Makefile, and I have readded it. If it fails the CI, this can be reconsidered.

rustbot assigned jieyouxu May 17, 2024

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 17, 2024

This comment has been minimized.
Sign in to view

Oneirical mentioned this pull request May 17, 2024
Migrate run-make/issue64319 to rmake and rename #125215
Merged

This comment has been minimized.
Sign in to view

jieyouxu reviewed May 17, 2024
View reviewed changes

jieyouxu mentioned this pull request May 20, 2024
Tracking Issue for porting run-make tests to use Rust #121876
Closed

Oneirical force-pushed the seventh branch from 4a9e416 to 0d31b22Compare May 21, 2024 01:46

This comment has been minimized.
Sign in to view

Oneirical mentioned this pull request May 21, 2024
Migrate run-make/issue-53964 to rmake#125224
Merged

jieyouxu reviewed May 21, 2024
View reviewed changes

Comment threadtests/run-make/reset-codegen-1/rmake.rs Outdated
Comment threadtests/run-make/reset-codegen-1/rmake.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 22, 2024

rewrite issue-30063
f377ea1

Oneirical force-pushed the seventh branch from ff01b2e to f377ea1Compare May 22, 2024 20:25

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2024

matthiaskrgr mentioned this pull request May 23, 2024
Rollup of 9 pull requests #125437
Closed

matthiaskrgr mentioned this pull request May 23, 2024
Rollup of 9 pull requests #125444
Closed

fmease mentioned this pull request May 23, 2024
Rollup of 7 pull requests #125456
Merged

bors merged commit d392d68 into rust-lang:masterMay 23, 2024

rustbot added this to the 1.80.0 milestone May 23, 2024

Oneirical deleted the seventh branch May 30, 2024 18:35

jieyouxu mentioned this pull request Jun 5, 2024
run-make-support: add wrapper for fs operations #125736
Merged

		// This test tries to reproduce this issue with varied emit flags - if it passes, the codegen-units
		// are being appropriately reset to 1 after each pass.

Uh oh!

Uh oh!

Conversation

Oneirical commented May 17, 2024

Uh oh!

rustbot commented May 17, 2024

Uh oh!

rustbot commented May 17, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

jieyouxuMay 17, 2024

Choose a reason for hiding this comment

Uh oh!

jieyouxuMay 17, 2024

Choose a reason for hiding this comment

Uh oh!

OneiricalMay 21, 2024

Choose a reason for hiding this comment

Uh oh!

bors commented May 18, 2024

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

jieyouxu commented May 21, 2024

Uh oh!

Oneirical commented May 22, 2024

Uh oh!

jieyouxu commented May 22, 2024

Uh oh!

bors commented May 22, 2024

Uh oh!

Oneirical commented May 22, 2024

Uh oh!

bors commented May 22, 2024

Uh oh!

jieyouxu commented May 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants