Uh oh!
There was an error while loading. Please reload this page.
-Znext-solver: eagerly normalize when adding goals - #125343
Merged
Merged
Conversation
lcnr
commented
May 20, 2024
ContributorAuthor
rustbot
commented
May 20, 2024
Collaborator
Uh oh!
There was an error while loading. Please reload this page.
rust-cloud-vmsBotforce-pushed
the
eagerly-normalize-added-goals
branch
from
May 21, 2024 19:56
413c979 to
9aa8308Comparelcnr
marked this pull request as ready for review
May 21, 2024 19:57
rustbot
commented
May 21, 2024
Collaborator
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler-errors
commented
May 22, 2024
Contributor
We discussed this, I'm happy with landing this for now I guess. We should track this optimization somewhere (ideally with a label in the new solver repo) so we can revisit it. @bors r+ |
bors
commented
May 22, 2024
Collaborator
lcnr
commented
May 22, 2024
ContributorAuthor
compiler-errors
commented
May 22, 2024
Contributor
@bors r- |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 24, 2024
…r=<try> drop region constraints for ambiguous goals See the comment in `compute_external_query_constraints`. While the underlying issue is preexisting, this fixes a bug introduced by rust-lang#125343. It slightly weakens the leak chec, even if we didn't have any test which was affected. I want to write such a test before merging this PR. r? `@compiler-errors`
bors
commented
May 25, 2024
Collaborator
☔ The latest upstream changes (presumably #125541) made this pull request unmergeable. Please resolve the merge conflicts. |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 25, 2024
…, r=compiler-errors drop region constraints for ambiguous goals See the comment in `compute_external_query_constraints`. While the underlying issue is preexisting, this fixes a bug introduced by rust-lang#125343. It slightly weakens the leak chec, even if we didn't have any test which was affected. I want to write such a test before merging this PR. r? `@compiler-errors`
fmease added a commit
to fmease/rust
that referenced
this pull request
May 26, 2024
…, r=compiler-errors drop region constraints for ambiguous goals See the comment in `compute_external_query_constraints`. While the underlying issue is preexisting, this fixes a bug introduced by rust-lang#125343. It slightly weakens the leak chec, even if we didn't have any test which was affected. I want to write such a test before merging this PR. r? ``@compiler-errors``
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 26, 2024
…, r=compiler-errors drop region constraints for ambiguous goals See the comment in `compute_external_query_constraints`. While the underlying issue is preexisting, this fixes a bug introduced by rust-lang#125343. It slightly weakens the leak chec, even if we didn't have any test which was affected. I want to write such a test before merging this PR. r? `@compiler-errors`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2024
…r=compiler-errors drop region constraints for ambiguous goals See the comment in `compute_external_query_constraints`. While the underlying issue is preexisting, this fixes a bug introduced by rust-lang#125343. It slightly weakens the leak chec, even if we didn't have any test which was affected. I want to write such a test before merging this PR. r? `@compiler-errors`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 27, 2024
…r=compiler-errors drop region constraints for ambiguous goals See the comment in `compute_external_query_constraints`. While the underlying issue is preexisting, this fixes a bug introduced by rust-lang#125343. It slightly weakens the leak chec, even if we didn't have any test which was affected. I want to write such a test before merging this PR. r? `@compiler-errors`
rust-cloud-vmsBotforce-pushed
the
eagerly-normalize-added-goals
branch
from
May 28, 2024 04:54
9aa8308 to
98bfd54Comparelcnr
commented
May 28, 2024
ContributorAuthor
@bors r=compiler-errors rollup |
bors
commented
May 28, 2024
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 28, 2024
…, r=compiler-errors `-Znext-solver`: eagerly normalize when adding goals fixesrust-lang#125269. I am not totally with this fix and going to keep this open until we have a more general discussion about how to handle hangs caused by lazy norm in the new solver.
workingjubilee added a commit
to workingjubilee/rustc
that referenced
this pull request
May 28, 2024
…, r=compiler-errors `-Znext-solver`: eagerly normalize when adding goals fixesrust-lang#125269. I am not totally with this fix and going to keep this open until we have a more general discussion about how to handle hangs caused by lazy norm in the new solver.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 28, 2024
…kingjubilee Rollup of 4 pull requests Successful merges: - rust-lang#125089 (Improve diagnostic output the `non_local_definitions` lint) - rust-lang#125343 (`-Znext-solver`: eagerly normalize when adding goals) - rust-lang#125411 (check host's libstdc++ version when using ci llvm) - rust-lang#125551 (Stabilise `IpvNAddr::{BITS, to_bits, from_bits}` (`ip_bits`)) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 28, 2024
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#125089 (Improve diagnostic output the `non_local_definitions` lint) - rust-lang#125343 (`-Znext-solver`: eagerly normalize when adding goals) - rust-lang#125551 (Stabilise `IpvNAddr::{BITS, to_bits, from_bits}` (`ip_bits`)) - rust-lang#125640 (Don't suggest turning non-char-literal exprs of ty `char` into string literals) - rust-lang#125647 (update tracking issue for lazy_cell_consume) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 28, 2024
Rollup merge of rust-lang#125343 - lcnr:eagerly-normalize-added-goals, r=compiler-errors `-Znext-solver`: eagerly normalize when adding goals fixesrust-lang#125269. I am not totally with this fix and going to keep this open until we have a more general discussion about how to handle hangs caused by lazy norm in the new solver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#125269. I am not totally with this fix and going to keep this open until we have a more general discussion about how to handle hangs caused by lazy norm in the new solver.