Uh oh!
There was an error while loading. Please reload this page.
Stop SRoA'ing DynMetadata in MIR - #125508
Merged
Merged
Conversation
rustbot
commented
May 24, 2024
Collaborator
rustbot
commented
May 24, 2024
Collaborator
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
matthiaskrgr
commented
May 24, 2024
Member
test? :3 |
| return true; | ||
| } | ||
| if Some(def.did()) == tcx.lang_items().dyn_metadata() { | ||
| // codegen wants to see the `DynMetadata<T>`, |
Member
There was a problem hiding this comment.
i actually think it's about time to investigate remove the layout special casing from dynmetadata and seeing what happens if you just let it be repr(transparent) :3
MemberAuthor
There was a problem hiding this comment.
Tried it out; #125532 (comment)
Looks like the hardest part might be dealing with whether the reference actually has AM memory behind it, and I have no idea how to solve that, so I'll stick with this change for now.
This comment has been minimized.
This comment has been minimized.
Noratrieb
commented
May 25, 2024
Member
@bors r+ |
bors
commented
May 25, 2024
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 25, 2024
Stop SRoA'ing `DynMetadata` in MIR Fixesrust-lang#125506
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125307 (tidy: stop special-casing tests/ui entry limit) - rust-lang#125375 (Create a triagebot ping group for Rust for Linux) - rust-lang#125413 (drop region constraints for ambiguous goals) - rust-lang#125433 (A small diagnostic improvement for dropping_copy_types) - rust-lang#125508 (Stop SRoA'ing `DynMetadata` in MIR) - rust-lang#125530 (cleanup dependence of `ExtCtxt` in transcribe when macro expansion) - rust-lang#125544 (Also mention my-self for other check-cfg docs changes) - rust-lang#125546 (Try to not reinstall tools in mingw CI) r? `@ghost` `@rustbot` modify labels: rollup
fmease added a commit
to fmease/rust
that referenced
this pull request
May 26, 2024
Stop SRoA'ing `DynMetadata` in MIR Fixesrust-lang#125506
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#125070 (Panic if `PathBuf::set_extension` would add a path separator) - rust-lang#125307 (tidy: stop special-casing tests/ui entry limit) - rust-lang#125375 (Create a triagebot ping group for Rust for Linux) - rust-lang#125413 (drop region constraints for ambiguous goals) - rust-lang#125433 (A small diagnostic improvement for dropping_copy_types) - rust-lang#125508 (Stop SRoA'ing `DynMetadata` in MIR) - rust-lang#125530 (cleanup dependence of `ExtCtxt` in transcribe when macro expansion) - rust-lang#125544 (Also mention my-self for other check-cfg docs changes) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#125070 (Panic if `PathBuf::set_extension` would add a path separator) - rust-lang#125307 (tidy: stop special-casing tests/ui entry limit) - rust-lang#125375 (Create a triagebot ping group for Rust for Linux) - rust-lang#125413 (drop region constraints for ambiguous goals) - rust-lang#125433 (A small diagnostic improvement for dropping_copy_types) - rust-lang#125508 (Stop SRoA'ing `DynMetadata` in MIR) - rust-lang#125530 (cleanup dependence of `ExtCtxt` in transcribe when macro expansion) - rust-lang#125544 (Also mention my-self for other check-cfg docs changes) r? `@ghost` `@rustbot` modify labels: rollup
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
May 26, 2024
Stop SRoA'ing `DynMetadata` in MIR Fixesrust-lang#125506
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#125307 (tidy: stop special-casing tests/ui entry limit) - rust-lang#125375 (Create a triagebot ping group for Rust for Linux) - rust-lang#125433 (A small diagnostic improvement for dropping_copy_types) - rust-lang#125508 (Stop SRoA'ing `DynMetadata` in MIR) - rust-lang#125530 (cleanup dependence of `ExtCtxt` in transcribe when macro expansion) - rust-lang#125544 (Also mention my-self for other check-cfg docs changes) - rust-lang#125546 (Try to not reinstall tools in mingw CI) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 26, 2024
Stop SRoA'ing `DynMetadata` in MIR Fixesrust-lang#125506
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125307 (tidy: stop special-casing tests/ui entry limit) - rust-lang#125375 (Create a triagebot ping group for Rust for Linux) - rust-lang#125413 (drop region constraints for ambiguous goals) - rust-lang#125433 (A small diagnostic improvement for dropping_copy_types) - rust-lang#125508 (Stop SRoA'ing `DynMetadata` in MIR) - rust-lang#125530 (cleanup dependence of `ExtCtxt` in transcribe when macro expansion) - rust-lang#125544 (Also mention my-self for other check-cfg docs changes) - rust-lang#125559 (Simplify the `unchecked_sh[lr]` ub-checks a bit) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 26, 2024
Stop SRoA'ing `DynMetadata` in MIR Fixesrust-lang#125506
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#125307 (tidy: stop special-casing tests/ui entry limit) - rust-lang#125375 (Create a triagebot ping group for Rust for Linux) - rust-lang#125433 (A small diagnostic improvement for dropping_copy_types) - rust-lang#125508 (Stop SRoA'ing `DynMetadata` in MIR) - rust-lang#125530 (cleanup dependence of `ExtCtxt` in transcribe when macro expansion) - rust-lang#125544 (Also mention my-self for other check-cfg docs changes) - rust-lang#125559 (Simplify the `unchecked_sh[lr]` ub-checks a bit) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 26, 2024
Stop SRoA'ing `DynMetadata` in MIR Fixesrust-lang#125506
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#125307 (tidy: stop special-casing tests/ui entry limit) - rust-lang#125375 (Create a triagebot ping group for Rust for Linux) - rust-lang#125473 (fix(opt-dist): respect existing config.toml) - rust-lang#125508 (Stop SRoA'ing `DynMetadata` in MIR) - rust-lang#125530 (cleanup dependence of `ExtCtxt` in transcribe when macro expansion) - rust-lang#125544 (Also mention my-self for other check-cfg docs changes) - rust-lang#125559 (Simplify the `unchecked_sh[lr]` ub-checks a bit) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2024
Stop SRoA'ing `DynMetadata` in MIR Fixesrust-lang#125506
bors
commented
May 26, 2024
Collaborator
bors
commented
May 26, 2024
Collaborator
💔 Test failed - checks-actions |
rust-log-analyzer
commented
May 26, 2024
Collaborator
A job failed! Check out the build log: (web)(plain) Click to see the possible cause of the failure (guessed by this bot) |
Noratrieb
commented
May 26, 2024
Member
skill issue |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#125307 (tidy: stop special-casing tests/ui entry limit) - rust-lang#125375 (Create a triagebot ping group for Rust for Linux) - rust-lang#125473 (fix(opt-dist): respect existing config.toml) - rust-lang#125508 (Stop SRoA'ing `DynMetadata` in MIR) - rust-lang#125561 (Stabilize `slice_flatten`) - rust-lang#125571 (f32: use constants instead of reassigning a dummy value as PI) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2024
Rollup merge of rust-lang#125508 - scottmcm:fix-125506, r=Nilstrieb Stop SRoA'ing `DynMetadata` in MIR Fixesrust-lang#125506
This was referenced May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#125506