Skip to content

Reintroduce name resolution check for trying to access locals from an inline const - #125705

Merged
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:const_block_ice
May 29, 2024
Merged

Reintroduce name resolution check for trying to access locals from an inline const#125705
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:const_block_ice

Conversation

@oli-obk

Copy link
Copy Markdown
Contributor

fixes#125676

I removed this without replacement in #124650 without considering the consequences

@rustbot

Copy link
Copy Markdown
Collaborator

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 29, 2024
@compiler-errors

Copy link
Copy Markdown
Contributor

r? compiler-errors @bors r+

@bors

bors commented May 29, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit bcfefe1 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 29, 2024
…r-errors
Reintroduce name resolution check for trying to access locals from an inline const
fixesrust-lang#125676
I removed this without replacement in rust-lang#124650 without considering the consequences
@Noratrieb

Copy link
Copy Markdown
Member

does this also fix #125670?

@lqd

lqd commented May 29, 2024

Copy link
Copy Markdown
Member

I don't believe so

bors added a commit to rust-lang-ci/rust that referenced this pull request May 29, 2024
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#107099 (rustdoc: Add support for --remap-path-prefix)
- rust-lang#125693 (Format all source files in `tests/coverage/`)
- rust-lang#125700 (coverage: Avoid overflow when the MC/DC condition limit is exceeded)
- rust-lang#125705 (Reintroduce name resolution check for trying to access locals from an inline const)
- rust-lang#125708 (tier 3 target policy: clarify the point about producing assembly)
- rust-lang#125715 (remove unneeded extern crate in rmake test)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request May 29, 2024
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#124655 (Add `-Zfixed-x18`)
- rust-lang#125693 (Format all source files in `tests/coverage/`)
- rust-lang#125700 (coverage: Avoid overflow when the MC/DC condition limit is exceeded)
- rust-lang#125705 (Reintroduce name resolution check for trying to access locals from an inline const)
- rust-lang#125708 (tier 3 target policy: clarify the point about producing assembly)
- rust-lang#125715 (remove unneeded extern crate in rmake test)
- rust-lang#125719 (Extract coverage-specific code out of `compiletest::runtest`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit c09b89e into rust-lang:masterMay 29, 2024
@rustbotrustbot added this to the 1.80.0 milestone May 29, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 29, 2024
Rollup merge of rust-lang#125705 - oli-obk:const_block_ice, r=compiler-errors
Reintroduce name resolution check for trying to access locals from an inline const
fixesrust-lang#125676
I removed this without replacement in rust-lang#124650 without considering the consequences
@fmease

Copy link
Copy Markdown
Member

bors sleepy @bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 29, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: mir_build: no entry found for key

8 participants

@oli-obk@rustbot@compiler-errors@bors@Noratrieb@lqd@fmease@BoxyUwU