Uh oh!
There was an error while loading. Please reload this page.
Migrate tests/run-make/prefer-dylib to rmake.rs - #126174
Merged
bors merged 1 commit intoJun 12, 2024
Merged
Conversation
rustbot
commented
Jun 8, 2024
Collaborator
Some changes occurred in run-make tests. cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomezforce-pushed
the
migrate-run-make-prefer-dylib
branch
from
June 8, 2024 22:09
0041bae to
b2c1a95CompareGuillaumeGomez
commented
Jun 8, 2024
MemberAuthor
Ah new API. This one looks better indeed! |
Kobzol
reviewed
Jun 9, 2024
Uh oh!
There was an error while loading. Please reload this page.
jieyouxu
approved these changes
Jun 9, 2024
jieyouxu
left a comment
Member
There was a problem hiding this comment.
Thanks! r=me after applying Kobzol's suggestion.
jieyouxu
commented
Jun 9, 2024
Member
@rustbot author |
GuillaumeGomezforce-pushed
the
migrate-run-make-prefer-dylib
branch
from
June 11, 2024 12:31
b2c1a95 to
19a2dfeComparejieyouxu
approved these changes
Jun 11, 2024
jieyouxu
left a comment
Member
There was a problem hiding this comment.
Thanks for the changes! r=me after CI is green.
Kobzol
commented
Jun 11, 2024
Member
@bors r=jieyouxu |
bors
commented
Jun 11, 2024
Collaborator
jieyouxu added a commit
to jieyouxu/rust
that referenced
this pull request
Jun 11, 2024
…efer-dylib, r=jieyouxu Migrate `tests/run-make/prefer-dylib` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#115974 (Split core's PanicInfo and std's PanicInfo) - rust-lang#125659 (Remove usage of `isize` in example) - rust-lang#125669 (CI: Update riscv64gc-linux job to Ubuntu 22.04, rename to riscv64gc-gnu) - rust-lang#125684 (Account for existing bindings when suggesting `pin!()`) - rust-lang#126055 (Expand list of trait implementers in E0277 when calling rustc with --verbose) - rust-lang#126174 (Migrate `tests/run-make/prefer-dylib` to `rmake.rs`) - rust-lang#126256 (Add {{target}} substitution to compiletest) r? `@ghost` `@rustbot` modify labels: rollup
jieyouxu added a commit
to jieyouxu/rust
that referenced
this pull request
Jun 11, 2024
…efer-dylib, r=jieyouxu Migrate `tests/run-make/prefer-dylib` to `rmake.rs` Part of rust-lang#121876. r? ``@jieyouxu``
This was referenced Jun 11, 2024
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#115974 (Split core's PanicInfo and std's PanicInfo) - rust-lang#125659 (Remove usage of `isize` in example) - rust-lang#125669 (CI: Update riscv64gc-linux job to Ubuntu 22.04, rename to riscv64gc-gnu) - rust-lang#125684 (Account for existing bindings when suggesting `pin!()`) - rust-lang#126055 (Expand list of trait implementers in E0277 when calling rustc with --verbose) - rust-lang#126174 (Migrate `tests/run-make/prefer-dylib` to `rmake.rs`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 12, 2024
Rollup merge of rust-lang#126174 - GuillaumeGomez:migrate-run-make-prefer-dylib, r=jieyouxu Migrate `tests/run-make/prefer-dylib` to `rmake.rs` Part of rust-lang#121876. r? ```@jieyouxu```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #121876.
r? @jieyouxu