Add Unicode block-drawing compiler output support by estebank · Pull Request #126597 · rust-lang/rust

estebank · 2024-06-17T15:14:51Z

Add nightly-only theming support to rustc output using Unicode box
drawing characters instead of ASCII-art to draw the terminal UI.

In order to enable, the flags -Zunstable-options=yes --error-format=human-unicode must be passed in.

After:

error: foo
╭▸ test.rs:3:3
│
3 │ X0 Y0 Z0
│ ┌───╿──│──┘
│ ┌│───│──┘
│ ┏││━━━┙
│ ┃││
4 │ ┃││ X1 Y1 Z1
5 │ ┃││ X2 Y2 Z2
│ ┃│└────╿──│──┘ `Z` label
│ ┃└─────│──┤
│ ┗━━━━━━┥ `Y` is a good letter too
│ `X` is a good letter
╰╴
note: bar
╭▸ test.rs:4:3
│
4 │ ┏ X1 Y1 Z1
5 │ ┃ X2 Y2 Z2
6 │ ┃ X3 Y3 Z3
│ ┗━━━━━━━━━━┛
├ note: bar
╰ note: baz
note: qux
╭▸ test.rs:4:3
│
4 │ X1 Y1 Z1
╰╴ ━━━━━━━━

Before:

error: foo
--> test.rs:3:3
|
3 | X0 Y0 Z0
| ___^__-__-
| |___|__|
| ||___|
| |||
4 | ||| X1 Y1 Z1
5 | ||| X2 Y2 Z2
| |||____^__-__- `Z` label
| ||_____|__|
| |______| `Y` is a good letter too
| `X` is a good letter
|
note: bar
--> test.rs:4:3
|
4 | / X1 Y1 Z1
5 | | X2 Y2 Z2
6 | | X3 Y3 Z3
| |__________^
= note: bar
= note: baz
note: qux
--> test.rs:4:3
|
4 | X1 Y1 Z1
| ^^^^^^^^

After:

Before:

rustbot · 2024-06-20T04:08:40Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

rustbot · 2024-06-20T23:17:55Z

Some changes occurred in tests/ui/check-cfg

cc @Urgau

estebank · 2024-06-20T23:18:11Z

r? compiler

bors · 2024-11-10T17:04:45Z

📌 Commit b53c0cb has been approved by fmease

It is now in the queue for this repository.

Add Unicode block-drawing compiler output support Add nightly-only theming support to rustc output using Unicode box drawing characters instead of ASCII-art to draw the terminal UI. In order to enable, the flags `-Zunstable-options=yes --error-format=human-unicode` must be passed in. After: ``` error: foo ╭▸ test.rs:3:3 │ 3 │ X0 Y0 Z0 │ ┌───╿──│──┘ │ ┌│───│──┘ │ ┏││━━━┙ │ ┃││ 4 │ ┃││ X1 Y1 Z1 5 │ ┃││ X2 Y2 Z2 │ ┃│└────╿──│──┘ `Z` label │ ┃└─────│──┤ │ ┗━━━━━━┥ `Y` is a good letter too │ `X` is a good letter ╰╴ note: bar ╭▸ test.rs:4:3 │ 4 │ ┏ X1 Y1 Z1 5 │ ┃ X2 Y2 Z2 6 │ ┃ X3 Y3 Z3 │ ┗━━━━━━━━━━┛ ├ note: bar ╰ note: baz note: qux ╭▸ test.rs:4:3 │ 4 │ X1 Y1 Z1 ╰╴ ━━━━━━━━ ``` Before: ``` error: foo --> test.rs:3:3 | 3 | X0 Y0 Z0 | ___^__-__- | |___|__| | ||___| | ||| 4 | ||| X1 Y1 Z1 5 | ||| X2 Y2 Z2 | |||____^__-__- `Z` label | ||_____|__| | |______| `Y` is a good letter too | `X` is a good letter | note: bar --> test.rs:4:3 | 4 | / X1 Y1 Z1 5 | | X2 Y2 Z2 6 | | X3 Y3 Z3 | |__________^ = note: bar = note: baz note: qux --> test.rs:4:3 | 4 | X1 Y1 Z1 | ^^^^^^^^ ``` After: ![rustc output with unicode box drawing characters](https://github.com/rust-lang/rust/assets/1606434/d210b79a-6579-4407-9706-ba8edc6e9f25) Before: ![current rustc output with ASCII art](https://github.com/rust-lang/rust/assets/1606434/5aecccf8-a6ee-4469-8b39-72fb0d979a9f)

bors · 2024-11-10T20:43:02Z

⌛ Testing commit b53c0cb with merge ecc8bb8...

bors · 2024-11-10T21:36:46Z

💔 Test failed - checks-actions

Add nightly-only theming support to rustc output using Unicode box drawing characters instead of ASCII-art to draw the terminal UI: After: ``` error: foo ╭▸ test.rs:3:3 │ 3 │ X0 Y0 Z0 │ ┌───╿──│──┘ │ ┌│───│──┘ │ ┏││━━━┙ │ ┃││ 4 │ ┃││ X1 Y1 Z1 5 │ ┃││ X2 Y2 Z2 │ ┃│└────╿──│──┘ `Z` label │ ┃└─────│──┤ │ ┗━━━━━━┥ `Y` is a good letter too │ `X` is a good letter ╰╴ note: bar ╭▸ test.rs:4:3 │ 4 │ ┏ X1 Y1 Z1 5 │ ┃ X2 Y2 Z2 6 │ ┃ X3 Y3 Z3 │ ┗━━━━━━━━━━┛ ├ note: bar ╰ note: baz note: qux ╭▸ test.rs:4:3 │ 4 │ X1 Y1 Z1 ╰╴ ━━━━━━━━ ``` Before: ``` error: foo --> test.rs:3:3 | 3 | X0 Y0 Z0 | ___^__-__- | |___|__| | ||___| | ||| 4 | ||| X1 Y1 Z1 5 | ||| X2 Y2 Z2 | |||____^__-__- `Z` label | ||_____|__| | |______| `Y` is a good letter too | `X` is a good letter | note: bar --> test.rs:4:3 | 4 | / X1 Y1 Z1 5 | | X2 Y2 Z2 6 | | X3 Y3 Z3 | |__________^ = note: bar = note: baz note: qux --> test.rs:4:3 | 4 | X1 Y1 Z1 | ^^^^^^^^ ```

fmease · 2024-11-10T22:57:50Z

@bors r+

bors · 2024-11-10T22:57:52Z

📌 Commit acf6344 has been approved by fmease

It is now in the queue for this repository.

bors · 2024-11-11T00:01:02Z

⌛ Testing commit acf6344 with merge 42b2496...

bors · 2024-11-11T02:30:05Z

☀️ Test successful - checks-actions
Approved by: fmease
Pushing 42b2496 to master...

rust-timer · 2024-11-11T03:49:18Z

Finished benchmarking commit (42b2496): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.3%	[5.3%, 5.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.9%	[-1.9%, -1.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.9%	[-1.9%, -1.9%]	1

Cycles

Results (secondary -2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.9%, -2.0%]	6
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 786.53s -> 786.761s (0.03%)
Artifact size: 335.31 MiB -> 335.30 MiB (-0.01%)

lqd · 2024-11-11T09:07:09Z

No worries, deep-vector is being noisy.

Probably the small period of calm below has lowered the significance threshold, making its usual (seemingly bad) variance trigger as regressions. This should """fix""" itself soon.

@rustbot label: +perf-regression-triaged

Add Unicode block-drawing compiler output support Add nightly-only theming support to rustc output using Unicode box drawing characters instead of ASCII-art to draw the terminal UI. In order to enable, the flags `-Zunstable-options=yes --error-format=human-unicode` must be passed in. After: ``` error: foo ╭▸ test.rs:3:3 │ 3 │ X0 Y0 Z0 │ ┌───╿──│──┘ │ ┌│───│──┘ │ ┏││━━━┙ │ ┃││ 4 │ ┃││ X1 Y1 Z1 5 │ ┃││ X2 Y2 Z2 │ ┃│└────╿──│──┘ `Z` label │ ┃└─────│──┤ │ ┗━━━━━━┥ `Y` is a good letter too │ `X` is a good letter ╰╴ note: bar ╭▸ test.rs:4:3 │ 4 │ ┏ X1 Y1 Z1 5 │ ┃ X2 Y2 Z2 6 │ ┃ X3 Y3 Z3 │ ┗━━━━━━━━━━┛ ├ note: bar ╰ note: baz note: qux ╭▸ test.rs:4:3 │ 4 │ X1 Y1 Z1 ╰╴ ━━━━━━━━ ``` Before: ``` error: foo --> test.rs:3:3 | 3 | X0 Y0 Z0 | ___^__-__- | |___|__| | ||___| | ||| 4 | ||| X1 Y1 Z1 5 | ||| X2 Y2 Z2 | |||____^__-__- `Z` label | ||_____|__| | |______| `Y` is a good letter too | `X` is a good letter | note: bar --> test.rs:4:3 | 4 | / X1 Y1 Z1 5 | | X2 Y2 Z2 6 | | X3 Y3 Z3 | |__________^ = note: bar = note: baz note: qux --> test.rs:4:3 | 4 | X1 Y1 Z1 | ^^^^^^^^ ``` After: ![rustc output with unicode box drawing characters](https://github.com/rust-lang/rust/assets/1606434/d210b79a-6579-4407-9706-ba8edc6e9f25) Before: ![current rustc output with ASCII art](https://github.com/rust-lang/rust/assets/1606434/5aecccf8-a6ee-4469-8b39-72fb0d979a9f)

estebank force-pushed the unicode-output branch from ab6dfc7 to bc3a6c2Compare June 19, 2024 16:01

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 19, 2024

estebank force-pushed the unicode-output branch 2 times, most recently from 0fb5d30 to 3b7a44fCompare June 20, 2024 02:04

estebank changed the title ~~[Experiment] Repalce ASCII compiler output with Unicode block-drawing~~Add Unicode block-drawing compiler output supportJun 20, 2024

estebank force-pushed the unicode-output branch from 3b7a44f to ffafff1Compare June 20, 2024 02:16

estebank marked this pull request as ready for review June 20, 2024 02:16

This comment was marked as resolved.
Sign in to view

estebank force-pushed the unicode-output branch from ffafff1 to 17b37f9Compare June 20, 2024 02:31

This comment has been minimized.
Sign in to view

estebank force-pushed the unicode-output branch from 17b37f9 to 9a606caCompare June 20, 2024 03:14

This comment has been minimized.
Sign in to view

estebank force-pushed the unicode-output branch from 9a606ca to bb62232Compare June 20, 2024 04:08

This comment was marked as resolved.
Sign in to view

Jake-Shadle mentioned this pull request Jun 20, 2024
Unicode block-drawing support brendanzab/codespan#362
Closed

estebank force-pushed the unicode-output branch from bb62232 to 5c77d3bCompare June 20, 2024 15:12

rustbot assigned fmease Jun 20, 2024

estebank commented Jun 20, 2024
View reviewed changes

Comment threadcompiler/rustc_errors/src/emitter.rs Outdated

This comment has been minimized.
Sign in to view

Urgau reviewed Jun 21, 2024
View reviewed changes

Comment threadtests/ui/check-cfg/cargo-build-script.stderr Outdated

This comment has been minimized.
Sign in to view

estebank added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2024

estebank commented Jun 21, 2024
View reviewed changes

Comment threadtests/ui/parser/recover/recover-labeled-non-block-expr.stderr

This comment was marked as resolved.
Sign in to view

estebank force-pushed the unicode-output branch 2 times, most recently from 57ff435 to 6fe519dCompare June 24, 2024 17:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2024

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 10, 2024

estebankand others added 2 commits November 10, 2024 23:57

Address review comments
acf6344

fmease force-pushed the unicode-output branch from b53c0cb to acf6344Compare November 10, 2024 22:57

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 11, 2024

bors merged commit 42b2496 into rust-lang:masterNov 11, 2024

rustbot added this to the 1.84.0 milestone Nov 11, 2024

rustbot added the perf-regression Performance regression. label Nov 11, 2024

rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 11, 2024

lqd mentioned this pull request Nov 11, 2024
Rollup of 3 pull requests #132885
Merged

epage mentioned this pull request Oct 28, 2025
Unicode renderer feedback rust-lang/annotate-snippets-rs#308
Open

epage mentioned this pull request Nov 6, 2025
Tracking Issue for --error-format=human-unicode#148607
Open
3 tasks

Uh oh!

Uh oh!

Conversation

estebank commented Jun 17, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment has been minimized.

This comment has been minimized.

rustbot commented Jun 20, 2024

Uh oh!

This comment was marked as resolved.

rustbot commented Jun 20, 2024

Uh oh!

estebank commented Jun 20, 2024

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

Uh oh!

This comment was marked as resolved.

bors commented Nov 10, 2024

Uh oh!

bors commented Nov 10, 2024

Uh oh!

This comment has been minimized.

bors commented Nov 10, 2024

Uh oh!

fmease commented Nov 10, 2024

Uh oh!

bors commented Nov 10, 2024

Uh oh!

bors commented Nov 11, 2024

Uh oh!

bors commented Nov 11, 2024

Uh oh!

rust-timer commented Nov 11, 2024

Overall result: ❌ regressions - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

lqd commented Nov 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

estebank commented Jun 17, 2024•
edited
Loading