Skip to content

std: add reserve_additional and an Extendable impl to Vec. - #12673

Merged
bors merged 1 commit into
rust-lang:masterfrom
huonw:extendable-vec
Mar 4, 2014
Merged

std: add reserve_additional and an Extendable impl to Vec.#12673
bors merged 1 commit into
rust-lang:masterfrom
huonw:extendable-vec

Conversation

@huonw

@huonwhuonw commented Mar 3, 2014

Copy link
Copy Markdown
Contributor

std: add reserve_additional and an Extendable impl to Vec.

@Aatch

Aatch commented Mar 3, 2014

Copy link
Copy Markdown
Contributor

Could you add some tests? It's not a huge issue, but it would be nice.

Comment threadsrc/libstd/vec_ng.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a newline here :)

@thestinger

Copy link
Copy Markdown
Contributor

@Aatch: I think this stuff does already have tests for ~[T]. The tests should probably be ported over to Vec<T> since ~[T] will be gone soon.

@Aatch

Aatch commented Mar 3, 2014

Copy link
Copy Markdown
Contributor

@thestinger I didn't realise that weren't actually any tests in vec_ng.

@huonw

huonw commented Mar 3, 2014

Copy link
Copy Markdown
ContributorAuthor

Now comes with free tests! (Don't miss out. Call now to place your order.)

bors added a commit that referenced this pull request Mar 3, 2014
std: add reserve_additional and an Extendable impl to Vec.
@borsbors closed this Mar 4, 2014
@bors
bors merged commit 6cb34cf into rust-lang:masterMar 4, 2014
@huonw
huonw deleted the extendable-vec branch June 27, 2014 06:48
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 18, 2024
…rs, r=blyxyas
[`ptr_as_ptr`]: Fix duplicate diagnostics
Relates to rust-lang/rust-clippy#12379
`ptr_as_ptr::check` is called twice in `clippy_lints/src/casts/mod.rs`
---
changelog: [`ptr_as_ptr`]: Fix duplicate diagnostics
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@huonw@Aatch@thestinger@bors