Uh oh!
There was an error while loading. Please reload this page.
On short error format, append primary span label to message - #126804
Merged
Conversation
estebank
marked this pull request as ready for review
June 21, 2024 19:23
rustbot
commented
Jun 21, 2024
Collaborator
r? @davidtwco rustbot has assigned @davidtwco. Use |
This comment has been minimized.
This comment has been minimized.
estebankforce-pushed
the
short-error-primary-label
branch
from
June 21, 2024 19:54
df6dcc2 to
35a6aecCompare
This comment has been minimized.
This comment has been minimized.
estebankforce-pushed
the
short-error-primary-label
branch
from
June 21, 2024 22:48
35a6aec to
57a82e0Comparedavidtwco
approved these changes
Jun 24, 2024
davidtwco
commented
Jun 24, 2024
Member
@bors r+ |
bors
commented
Jun 24, 2024
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 24, 2024
…, r=davidtwco On short error format, append primary span label to message The `error-format=short` output only displays the path, error code and main error message all in the same line. We now add the primary span label as well after the error message, to provide more context.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 24, 2024
…, r=davidtwco On short error format, append primary span label to message The `error-format=short` output only displays the path, error code and main error message all in the same line. We now add the primary span label as well after the error message, to provide more context.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#124460 (Show notice about "never used" of Debug for enum) - rust-lang#125740 (transmute size check: properly account for alignment) - rust-lang#126413 (compiletest: make the crash test error message abit more informative) - rust-lang#126618 (Mark assoc tys live only if the corresponding trait is live) - rust-lang#126673 (Ensure we don't accidentally succeed when we want to report an error) - rust-lang#126804 (On short error format, append primary span label to message) - rust-lang#126868 (not use offset when there is not ends with brace) - rust-lang#126893 (Eliminate the distinction between PREC_POSTFIX and PREC_PAREN precedence level) - rust-lang#126899 (Suggest inline const blocks for array initialization) - rust-lang#126909 (add `@kobzol` to bootstrap team for triagebot) r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors
commented
Jun 24, 2024
Contributor
I believe this failed in a rollup: #126912 (comment) @bors r- rollup=iffy |
estebank
commented
Jun 25, 2024
ContributorAuthor
Blocked on rust-lang/cargo#14135. |
estebankforce-pushed
the
short-error-primary-label
branch
from
July 31, 2024 23:05
57a82e0 to
8b7ff89Compareestebank
commented
Jul 31, 2024
ContributorAuthor
@bors r=davidtwco |
bors
commented
Jul 31, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 1, 2024
…r=davidtwco On short error format, append primary span label to message The `error-format=short` output only displays the path, error code and main error message all in the same line. We now add the primary span label as well after the error message, to provide more context.
bors
commented
Aug 1, 2024
Collaborator
This comment has been minimized.
This comment has been minimized.
bors
commented
Aug 1, 2024
Collaborator
💔 Test failed - checks-actions |
The `error-format=short` output only displays the path, error code and main error message all in the same line. We now add the primary span label as well after the error message, to provide more context.
estebankforce-pushed
the
short-error-primary-label
branch
from
August 6, 2024 04:24
8b7ff89 to
1bbaf6eCompareestebank
commented
Aug 6, 2024
ContributorAuthor
@bors r=davidtwco |
bors
commented
Aug 6, 2024
Collaborator
bors
commented
Aug 6, 2024
Collaborator
bors
commented
Aug 6, 2024
Collaborator
☀️ Test successful - checks-actions |
This was referenced Aug 6, 2024
rust-timer
commented
Aug 6, 2024
Collaborator
Finished benchmarking commit (93ea767): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 760.794s -> 760.454s (-0.04%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
error-format=shortoutput only displays the path, error code and main error message all in the same line. We now add the primary span label as well after the error message, to provide more context.