Migrate `run-make/invalid-library` to `rmake.rs` by GuillaumeGomez · Pull Request #126861 · rust-lang/rust

GuillaumeGomez · 2024-06-23T13:12:45Z

try-job: x86_64-msvc

rustbot · 2024-06-23T13:12:54Z

The run-make-support library was changed

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

Kobzol · 2024-06-23T17:10:05Z

r? @Kobzol

Thanks!

@bors r+

bors · 2024-06-23T17:10:08Z

📌 Commit 10990e2 has been approved by Kobzol

It is now in the queue for this repository.

…valid-library, r=Kobzol Migrate `run-make/invalid-library` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu`

…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#126177 (Add hard error and migration lint for unsafe attrs) - rust-lang#126298 (Promote loongarch64-unknown-linux-musl to Tier 2 with host tools) - rust-lang#126455 (For [E0308]: mismatched types, when expr is in an arm's body, not add semicolon ';' at the end of it.) - rust-lang#126754 (Implement `use<>` formatting in rustfmt) - rust-lang#126807 (std::unix::fs: copy simplification for apple.) - rust-lang#126845 (Weekly `cargo update`) - rust-lang#126849 (Fix 32-bit Arm reg classes by hierarchically sorting them) - rust-lang#126854 (std::unix::os::home_dir: fallback's optimisation.) - rust-lang#126861 (Migrate `run-make/invalid-library` to `rmake.rs`) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-06-24T04:28:02Z

@bors r-
#126886 (comment)

jieyouxu · 2024-06-24T04:32:50Z

Oh yeah this is another case of I can't seem to figure out if/when AR is available on Windows platforms (//@ needs-ar?)

rustbot · 2024-06-24T09:06:19Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

GuillaumeGomez · 2024-06-24T09:07:15Z

@bors try

bors · 2024-06-24T09:08:24Z

⌛ Trying commit 22cac46 with merge 4f44f04...

…lid-library, r=<try> Migrate `run-make/invalid-library` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu` try-job: x86_64-msvc

Kobzol · 2024-06-24T09:09:27Z

Maybe a more general solution is to just use e.g. https://docs.rs/ar/latest/ar/ instead of an external binary?

GuillaumeGomez · 2024-06-24T09:12:03Z

Do you want it to be part of this PR (and as part of run_make_support) or as a follow-up?

Kobzol · 2024-06-24T09:29:05Z

Doesn't need to be a part of this PR, although if it does indeed work reliably (even on Windows), then maybe we might remove needs-ar in the future.

GuillaumeGomez · 2024-06-24T09:30:23Z

Doing it in this PR then.

rustbot · 2024-06-24T09:47:46Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

GuillaumeGomez · 2024-06-24T09:48:11Z

It now uses the ar crate.

bors · 2024-06-26T10:34:32Z

☔ The latest upstream changes (presumably #126979) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez · 2024-06-27T12:05:48Z

Fixed merge conflicts.

Kobzol · 2024-06-27T12:45:11Z

@bors try

…lid-library, r=<try> Migrate `run-make/invalid-library` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu` try-job: x86_64-msvc

bors · 2024-06-27T12:46:21Z

⌛ Trying commit 3394fe8 with merge 529edc7...

bors · 2024-06-27T14:23:41Z

☀️ Try build successful - checks-actions
Build commit: 529edc7 (529edc73f0339424ce56ae32649b7e162f005258)

Kobzol · 2024-06-27T14:31:30Z

The previously failed job now works, let's try again.

@bors r+

bors · 2024-06-27T14:31:32Z

📌 Commit 3394fe8 has been approved by Kobzol

It is now in the queue for this repository.

Kobzol · 2024-06-27T14:31:44Z

@bors rollup=iffy

bors · 2024-06-27T14:37:57Z

⌛ Testing commit 3394fe8 with merge 2495953...

bors · 2024-06-27T17:07:47Z

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 2495953 to master...

rust-timer · 2024-06-27T18:28:41Z

Finished benchmarking commit (2495953): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -6.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-6.7%	[-6.7%, -6.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-6.7%	[-6.7%, -6.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 697.296s -> 695.757s (-0.22%)
Artifact size: 326.82 MiB -> 326.76 MiB (-0.02%)

rustbot assigned jieyouxu Jun 23, 2024

GuillaumeGomez changed the title ~~Migrate run make invalid library~~Migrate run-make/invalid-library to rmake.rsJun 23, 2024

Kobzol mentioned this pull request Jun 23, 2024
Tracking Issue for porting run-make tests to use Rust #121876
Closed

rustbot assigned Kobzol Jun 23, 2024

rustbot unassigned jieyouxu Jun 23, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2024

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 24, 2024
Rollup merge ofrust-lang#126861- GuillaumeGomez:migrate-run-make-in…
969bbc6
…valid-library, r=Kobzol Migrate `run-make/invalid-library` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu`

workingjubilee mentioned this pull request Jun 24, 2024
Rollup of 9 pull requests #126886
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2024

GuillaumeGomez force-pushed the migrate-run-make-invalid-library branch from f62afdc to 22cac46Compare June 24, 2024 09:07

GuillaumeGomez force-pushed the migrate-run-make-invalid-library branch from 22cac46 to 8a644ffCompare June 24, 2024 09:47

This comment has been minimized.
Sign in to view

GuillaumeGomez added 3 commits June 27, 2024 14:04

Add ar_command in run_make_support
84146b3

Migrate run-make/invalid-library to rmake.rs
449cde3

Add ar command in run-make-support
3394fe8

GuillaumeGomez force-pushed the migrate-run-make-invalid-library branch from 8a644ff to 3394fe8Compare June 27, 2024 12:05

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 27, 2024

bors merged commit 2495953 into rust-lang:masterJun 27, 2024

rustbot added this to the 1.81.0 milestone Jun 27, 2024

GuillaumeGomez deleted the migrate-run-make-invalid-library branch June 27, 2024 17:40

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Jun 23, 2024• edited by jieyouxu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 23, 2024

Uh oh!

Kobzol commented Jun 23, 2024

Uh oh!

bors commented Jun 23, 2024

Uh oh!

matthiaskrgr commented Jun 24, 2024

Uh oh!

jieyouxu commented Jun 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 24, 2024

Uh oh!

GuillaumeGomez commented Jun 24, 2024

Uh oh!

bors commented Jun 24, 2024

Uh oh!

Kobzol commented Jun 24, 2024

Uh oh!

GuillaumeGomez commented Jun 24, 2024

Uh oh!

Kobzol commented Jun 24, 2024

Uh oh!

GuillaumeGomez commented Jun 24, 2024

Uh oh!

rustbot commented Jun 24, 2024

Uh oh!

GuillaumeGomez commented Jun 24, 2024

Uh oh!

This comment has been minimized.

bors commented Jun 26, 2024

Uh oh!

GuillaumeGomez commented Jun 27, 2024

Uh oh!

Kobzol commented Jun 27, 2024

Uh oh!

bors commented Jun 27, 2024

Uh oh!

bors commented Jun 27, 2024

Uh oh!

Kobzol commented Jun 27, 2024

Uh oh!

bors commented Jun 27, 2024

Uh oh!

Kobzol commented Jun 27, 2024

Uh oh!

bors commented Jun 27, 2024

Uh oh!

bors commented Jun 27, 2024

Uh oh!

rust-timer commented Jun 27, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

GuillaumeGomez commented Jun 23, 2024•
edited by jieyouxu
Loading

jieyouxu commented Jun 24, 2024•
edited
Loading