Skip to content

Add parse fail test using safe trait/impl trait - #127248

Merged
bors merged 1 commit into
rust-lang:masterfrom
spastorino:unsafe-extern-tests
Jul 3, 2024
Merged

Add parse fail test using safe trait/impl trait#127248
bors merged 1 commit into
rust-lang:masterfrom
spastorino:unsafe-extern-tests

Conversation

@spastorino

Copy link
Copy Markdown
Member

Added 2 more tests to be sure that nothing weird happens using safe on items.
Needed to do this in separate tests as they give parsing errors.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 2, 2024
Comment threadtests/ui/rust-2024/unsafe-extern-blocks/safe-trait.rs Outdated
Comment threadtests/ui/rust-2024/unsafe-extern-blocks/safe-impl-trait.rs Outdated
@compiler-errors

Copy link
Copy Markdown
Contributor

Please fix the test error annotations, then r=me

@spastorino
spastorinoforce-pushed the unsafe-extern-tests branch from cb478d2 to 8b6435dCompareJuly 3, 2024 15:09
@spastorino

Copy link
Copy Markdown
MemberAuthor

@bors r=compiler-errors rollup

@bors

bors commented Jul 3, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 8b6435d has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 3, 2024
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#126803 (Change `asm-comments` to `verbose-asm`, always emit user comments)
- rust-lang#127050 (Make mtime of reproducible tarballs dependent on git commit)
- rust-lang#127145 (Add `as_lang_item` to `LanguageItems`, new trait solver)
- rust-lang#127202 (Remove global error count checks from typeck)
- rust-lang#127233 (Some parser cleanups)
- rust-lang#127248 (Add parse fail test using safe trait/impl trait)
- rust-lang#127264 (Small `run-make-support` API improvements)
- rust-lang#127270 (bootstrap: pass correct struct size to winapi)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit ce991da into rust-lang:masterJul 3, 2024
@rustbotrustbot added this to the 1.81.0 milestone Jul 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 3, 2024
Rollup merge of rust-lang#127248 - spastorino:unsafe-extern-tests, r=compiler-errors
Add parse fail test using safe trait/impl trait
Added 2 more tests to be sure that nothing weird happens using `safe` on items.
Needed to do this in separate tests as they give parsing errors.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@spastorino@rustbot@compiler-errors@bors@Nadrieril