Uh oh!
There was an error while loading. Please reload this page.
coverage: Rename mir::coverage::BranchInfo to CoverageInfoHi - #127352
Merged
Conversation
rustbot
commented
Jul 5, 2024
Collaborator
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
commented
Jul 5, 2024
Collaborator
Some changes occurred in match lowering cc @Nadrieril Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Zalathar
commented
Jul 5, 2024
MemberAuthor
Originally I was also planning to rename So the slightly-inconsistent names make it easier to get a mental foothold on which is which, especially since they are used in places that mostly don't overlap. |
This comment has been minimized.
This comment has been minimized.
This opens the door to collecting and storing coverage information that is unrelated to branch coverage or MC/DC.
oli-obk
commented
Jul 5, 2024
Contributor
bors
commented
Jul 5, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 5, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#124290 (DependencyList: removed outdated comment) - rust-lang#126709 (Migrate `include_bytes_deps`, `optimization-remarks-dir-pgo`, `optimization-remarks-dir`, `issue-40535` and `rmeta-preferred` `run-make` tests to rmake) - rust-lang#127214 (Use the native unwind function in miri where possible) - rust-lang#127320 (Update windows-bindgen to 0.58.0) - rust-lang#127349 (Tweak `-1 as usize` suggestion) - rust-lang#127352 (coverage: Rename `mir::coverage::BranchInfo` to `CoverageInfoHi`) - rust-lang#127359 (Improve run make llvm ident code) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 5, 2024
Rollup merge of rust-lang#127352 - Zalathar:coverage-info, r=oli-obk coverage: Rename `mir::coverage::BranchInfo` to `CoverageInfoHi` This opens the door to collecting and storing coverage information that is unrelated to branch coverage or MC/DC, during MIR building. There is no change to the output of coverage instrumentation, but one deliberate change is that functions now *always* have an attached `CoverageInfoHi` (if coverage is enabled and they are eligible), even if they didn't collect any interesting branch information. --- `@rustbot` label +A-code-coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This opens the door to collecting and storing coverage information that is unrelated to branch coverage or MC/DC, during MIR building.
There is no change to the output of coverage instrumentation, but one deliberate change is that functions now always have an attached
CoverageInfoHi(if coverage is enabled and they are eligible), even if they didn't collect any interesting branch information.@rustbot label +A-code-coverage