Skip to content

rustdoc-json: add type/trait alias tests - #127459

Merged
bors merged 1 commit into
rust-lang:masterfrom
its-the-shrimp:rustdocjson_add_alias_tests
Jul 8, 2024
Merged

rustdoc-json: add type/trait alias tests#127459
bors merged 1 commit into
rust-lang:masterfrom
its-the-shrimp:rustdocjson_add_alias_tests

Conversation

@its-the-shrimp

@its-the-shrimpits-the-shrimp commented Jul 7, 2024•
edited by aDotInTheVoid
Loading

Copy link
Copy Markdown
Contributor

Not sure if this tests everything there is to test in them though.

Updates #81359

@rustbot

rustbot commented Jul 7, 2024

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 7, 2024
@its-the-shrimp

its-the-shrimp commented Jul 7, 2024

Copy link
Copy Markdown
ContributorAuthor

r? @aDotInTheVoid

compiler-errors
compiler-errors reviewed Jul 7, 2024
View reviewed changes
Comment threadtests/rustdoc-json/trait_alias.rs
@aDotInTheVoidaDotInTheVoid added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jul 8, 2024
@aDotInTheVoid

aDotInTheVoid commented Jul 8, 2024

Copy link
Copy Markdown
Member

Thanks! As a potential followup, it'd be nice to also test for these when re-exporting, as that distinction seems more susceptible to being lost there. But that isn't necessary to make this worth merging.

@bors r+ rollup

@bors

bors commented Jul 8, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 8e7314f has been approved by aDotInTheVoid

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jul 8, 2024
@jieyouxu
Rollup merge ofrust-lang#127459- its-the-shrimp:rustdocjson_add_ali…
d200683
…as_tests, r=aDotInTheVoid
rustdoc-json: add type/trait alias tests
Not sure if this tests everything there is to test in them though.
Updates rust-lang#81359
@jieyouxujieyouxu mentioned this pull request Jul 8, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 8, 2024
@bors
Auto merge ofrust-lang#127475- jieyouxu:rollup-ayualfk, r=jieyouxu
3700bb5
Rollup of 12 pull requests
Successful merges:
- rust-lang#113128 (Support tail calls in mir via `TerminatorKind::TailCall`)
- rust-lang#126841 ([`macro_metavar_expr_concat`] Add support for literals)
- rust-lang#126881 (Make `NEVER_TYPE_FALLBACK_FLOWING_INTO_UNSAFE` a deny-by-default lint in edition 2024)
- rust-lang#126921 (Give VaList its own home)
- rust-lang#127276 (rustdoc: Remove OpaqueTy)
- rust-lang#127367 (Run alloc sync tests)
- rust-lang#127431 (Use field ident spans directly instead of the full field span in diagnostics on local fields)
- rust-lang#127437 (Uplift trait ref is knowable into `rustc_next_trait_solver`)
- rust-lang#127439 (Uplift elaboration into `rustc_type_ir`)
- rust-lang#127451 (Improve `run-make/output-type-permutations` code and improve `filename_not_in_denylist` API)
- rust-lang#127452 (Fix intrinsic const parameter counting with `effects`)
- rust-lang#127459 (rustdoc-json: add type/trait alias tests)
r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxujieyouxu mentioned this pull request Jul 8, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 8, 2024
@bors
Auto merge ofrust-lang#127476- jieyouxu:rollup-16wyb0b, r=jieyouxu
7fdefb8
Rollup of 10 pull requests
Successful merges:
- rust-lang#126841 ([`macro_metavar_expr_concat`] Add support for literals)
- rust-lang#126881 (Make `NEVER_TYPE_FALLBACK_FLOWING_INTO_UNSAFE` a deny-by-default lint in edition 2024)
- rust-lang#126921 (Give VaList its own home)
- rust-lang#127367 (Run alloc sync tests)
- rust-lang#127431 (Use field ident spans directly instead of the full field span in diagnostics on local fields)
- rust-lang#127437 (Uplift trait ref is knowable into `rustc_next_trait_solver`)
- rust-lang#127439 (Uplift elaboration into `rustc_type_ir`)
- rust-lang#127451 (Improve `run-make/output-type-permutations` code and improve `filename_not_in_denylist` API)
- rust-lang#127452 (Fix intrinsic const parameter counting with `effects`)
- rust-lang#127459 (rustdoc-json: add type/trait alias tests)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 76be8f1 into rust-lang:masterJul 8, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 8, 2024
@rust-timer
Unrolled build forrust-lang#127459
b080058
Rollup merge of rust-lang#127459 - its-the-shrimp:rustdocjson_add_alias_tests, r=aDotInTheVoid
rustdoc-json: add type/trait alias tests
Not sure if this tests everything there is to test in them though.
Updates rust-lang#81359
@rustbotrustbot added this to the 1.81.0 milestone Jul 8, 2024
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 11, 2024
@bors
Auto merge ofrust-lang#127476- jieyouxu:rollup-16wyb0b, r=jieyouxu
e82cfdc
Rollup of 10 pull requests
Successful merges:
- rust-lang#126841 ([`macro_metavar_expr_concat`] Add support for literals)
- rust-lang#126881 (Make `NEVER_TYPE_FALLBACK_FLOWING_INTO_UNSAFE` a deny-by-default lint in edition 2024)
- rust-lang#126921 (Give VaList its own home)
- rust-lang#127367 (Run alloc sync tests)
- rust-lang#127431 (Use field ident spans directly instead of the full field span in diagnostics on local fields)
- rust-lang#127437 (Uplift trait ref is knowable into `rustc_next_trait_solver`)
- rust-lang#127439 (Uplift elaboration into `rustc_type_ir`)
- rust-lang#127451 (Improve `run-make/output-type-permutations` code and improve `filename_not_in_denylist` API)
- rust-lang#127452 (Fix intrinsic const parameter counting with `effects`)
- rust-lang#127459 (rustdoc-json: add type/trait alias tests)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@compiler-errorscompiler-errorscompiler-errors left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@aDotInTheVoidaDotInTheVoid

Labels

A-rustdoc-jsonArea: Rustdoc JSON backendA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.81.0

Development

Successfully merging this pull request may close these issues.

6 participants

@its-the-shrimp@rustbot@aDotInTheVoid@bors@compiler-errors@Mark-Simulacrum