Migrate 9 more very similar FFI `run-make` tests to rmake by Oneirical · Pull Request #127663 · rust-lang/rust

Oneirical · 2024-07-12T20:00:15Z

Part of #121876 and the associated Google Summer of Code project.

For the tracking issue:

return-non-c-like-enum-from-c
pass-non-c-like-enum-to-c
c-static-dylib
c-static-rlib
extern-fn-generic
extern-fn-with-union
lto-no-link-whole-rlib
linkage-attr-on-static
issue-28595

rustbot · 2024-07-12T20:00:24Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-07-12T20:00:26Z

The run-make-support library was changed

cc @jieyouxu

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu · 2024-07-14T10:13:49Z

Question: should this be blocked on another PR that also introduces the build_native_lib helper?
@rustbot author

Oneirical · 2024-07-15T15:45:34Z

Yes, it should be.
@rustbot blocked #126208

2024-07-12T21:01:28.3065014Z thread 'main' panicked at src/tools/compiletest/src/header.rs:47:41:
2024-07-12T21:01:28.3065873Z open test file to parse earlyprops: Os { code: 20, kind: NotADirectory, message: "Not a directory" }
2024-07-12T21:01:28.3066711Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Also, this CI failure is VERY weird. It doesn't seem related to what this PR changes.

Oneirical · 2024-07-17T15:08:16Z

@rustbot blocked (now on #127760)

jieyouxu · 2024-07-17T18:27:48Z

@rustbot author (pr was merged)

bors · 2024-07-17T18:58:19Z

☔ The latest upstream changes (presumably #127760) made this pull request unmergeable. Please resolve the merge conflicts.

Oneirical · 2024-07-17T19:25:32Z

Just noticed it was failing because one of the files didn't get bundled with my commits. Please add issue-28595 in the tracking issue.

Oneirical · 2024-07-17T20:57:04Z

@rustbot review

Oneirical · 2024-07-19T16:28:21Z

@bors r=@jieyouxu
Fifth time's the charm?

bors · 2024-07-19T16:28:24Z

📌 Commit fdc8d62 has been approved by jieyouxu

It is now in the queue for this repository.

Migrate 9 more very similar FFI `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). For the tracking issue: - return-non-c-like-enum-from-c - pass-non-c-like-enum-to-c - c-static-dylib - c-static-rlib - extern-fn-generic - extern-fn-with-union - lto-no-link-whole-rlib - linkage-attr-on-static - issue-28595

bors · 2024-07-20T19:49:52Z

⌛ Testing commit fdc8d62 with merge 5069856...

bors · 2024-07-20T22:13:33Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 5069856 to master...

rust-timer · 2024-07-20T23:31:08Z

Finished benchmarking commit (5069856): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.5%	[-2.5%, -2.5%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.36s -> 769.446s (-0.25%)
Artifact size: 328.85 MiB -> 328.90 MiB (0.02%)

rustbot assigned jieyouxu Jul 12, 2024

This comment has been minimized.
Sign in to view

Oneirical force-pushed the fuzzy-testure branch 2 times, most recently from 56e301d to 55b9323Compare July 12, 2024 20:09

This comment has been minimized.
Sign in to view

Kobzol mentioned this pull request Jul 12, 2024
Tracking Issue for porting run-make tests to use Rust #121876
Closed

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2024

rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2024

Oneirical force-pushed the fuzzy-testure branch from 55b9323 to 2f31447Compare July 17, 2024 15:06

This comment has been minimized.
Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jul 17, 2024

Oneirical changed the title ~~Migrate 8 more very similar FFI run-make tests to rmake~~Migrate 9 more very similar FFI run-make tests to rmakeJul 17, 2024

Oneirical force-pushed the fuzzy-testure branch from 6423fd9 to 5d40df3Compare July 17, 2024 19:30

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 17, 2024

Oneirical added 9 commits July 19, 2024 12:27

rewrite return-non-c-like-enum-from-c to rmake
5b1860a

rewrite and rename issue-28595 to rmake
5e55f07

rewrite c-static-dylib to rmake
1ae1ab8

rewrite c-static-rlib to rmake
1a4fba5

rewrite extern-fn-generic to rmake
8a09f22

rewrite extern-fn-with-union to rmake
01c7118

rewrite lto-no-link-whole-rlib to rmake
db8398d

rewrite linkage-attr-on-static to rmake
1f976b4

rewrite pass-non-c-like-enum-to-c to rmake
fdc8d62

Oneirical force-pushed the fuzzy-testure branch from 2d3e595 to fdc8d62Compare July 19, 2024 16:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2024

tgross35 mentioned this pull request Jul 20, 2024
Rollup of 8 pull requests #128000
Closed

tgross35 mentioned this pull request Jul 20, 2024
Rollup of 7 pull requests #128003
Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 20, 2024

bors merged commit 5069856 into rust-lang:masterJul 20, 2024

rustbot added this to the 1.81.0 milestone Jul 20, 2024

matthiaskrgr mentioned this pull request Apr 29, 2025
ICE: expand: unimplemented #140479
Closed

Uh oh!

Uh oh!

Conversation

Oneirical commented Jul 12, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 12, 2024

Uh oh!

rustbot commented Jul 12, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

jieyouxu commented Jul 14, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Oneirical commented Jul 15, 2024

Uh oh!

Oneirical commented Jul 17, 2024

Uh oh!

This comment has been minimized.

jieyouxu commented Jul 17, 2024

Uh oh!

bors commented Jul 17, 2024

Uh oh!

Oneirical commented Jul 17, 2024

Uh oh!

Oneirical commented Jul 17, 2024

Uh oh!

Oneirical commented Jul 19, 2024

Uh oh!

bors commented Jul 19, 2024

Uh oh!

bors commented Jul 20, 2024

Uh oh!

bors commented Jul 20, 2024

Uh oh!

rust-timer commented Jul 20, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Oneirical commented Jul 12, 2024•
edited
Loading

jieyouxu commented Jul 14, 2024•
edited
Loading